Correct closing of NODE_ITEM #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When OnEndElement(...) is called ctxt.in_item is still > 0. Therefore checking if the closing node is NODE_ITEM needs to happen inside that conditional block to decrease ctxt.in_item and possibly stop parsing.
|
I'm sorry, but even after several re-readings, I don't understand why you want to make the change. The commit message explains what the change is (something the code already answers), but not why. Can you please explain what is handled incorrectly and provide an example feed content that demonstrates it? TIA! |
|
As far as I can see the code to preliminary stop parsing can never be called. It seemed not to be intended. That is why I proposed this PR. Maybe I am missing something and the original code is perfectly fine - in that case this PR of course can be discarded. |
|
No, you're right, I just couldn't understand what you were saying, because that bug was so absurd it didn't register... Sorry for being slow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When OnEndElement(...) is called ctxt.in_item is still > 0. Therefore checking if the closing node is NODE_ITEM needs to happen inside that conditional block to decrease ctxt.in_item and possibly stop parsing.