gh-18 prevent data race in extension looker upper through lock

weaviate · Dec 3, 2019 · a295c8d · a295c8d
1 parent de4e50d
commit a295c8d
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/extensions/looker_upper.go b/extensions/looker_upper.go
@@ -26,6 +26,9 @@ func NewLookerUpper(repo RetrieverRepo) *LookerUpper {
 }
 
 func (lu *LookerUpper) Lookup(concept string) (*Extension, error) {
+	lu.Lock()
+	defer lu.Unlock()
+
 	ext, ok := lu.db[concept]
 	if !ok {
 		return nil, nil
@@ -41,17 +44,16 @@ func (lu *LookerUpper) initWatcher() {
 
 	go func() {
 		for res := range updateCh {
-			// lu.Lock()
-			// defer lu.Unlock()
-
 			lu.updateDB(res)
 		}
 	}()
 }
 
 func (lu *LookerUpper) updateDB(list []Extension) {
+	lu.Lock()
+	defer lu.Unlock()
+
 	for _, ext := range list {
 		lu.db[ext.Concept] = ext
 	}
-
 }