Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: connect to upgrade-personal-to-team API #WPB-11992 #3625

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

damian-kaczmarek
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek commented Nov 13, 2024

TaskWPB-11992 [Android] Team creation for personal user - connect to the API - /upgrade-personal-to-team


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Adds calls to the API when migrating from personal to team account.

Needs releases with:

Testing

Test Coverage (Optional)

Work in progress

  • I have added automated test to this contribution

How to Test

To test you need to switch to anta
https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/300351887/Testing+environments+for+federation#anta

The html with deeplinks switching can be downloaded here. You must logout first before switching. https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/300351887/Testing+environments+for+federation#anta

To get signup code you must read the email from inbucket.
Password is on 1password.

Then:

  • create personal account
  • go to you profile page, at the top you will see migration banner
  • go through the process
  • at the you should see success screen
  • currently you will only see changes to your account after app restart, WIP: https://wearezeta.atlassian.net/browse/WPB-12187

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@damian-kaczmarek damian-kaczmarek self-assigned this Nov 13, 2024
@damian-kaczmarek damian-kaczmarek changed the title feature: connect to upgrade-personal-to-team API #WPB-11992 feat: connect to upgrade-personal-to-team API #WPB-11992 Nov 13, 2024
Copy link
Contributor

@damian-kaczmarek looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
f69841cbc9faee3dc4fd110e4fc75a5404e3b21c f60103a0c57a269263c5335146f7896e83bd8046

Is this intentional?

Copy link
Contributor

@damian-kaczmarek looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
f69841cbc9faee3dc4fd110e4fc75a5404e3b21c f60103a0c57a269263c5335146f7896e83bd8046

Is this intentional?

Copy link
Contributor

@damian-kaczmarek looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
f69841cbc9faee3dc4fd110e4fc75a5404e3b21c f60103a0c57a269263c5335146f7896e83bd8046

Is this intentional?

Copy link
Contributor

@damian-kaczmarek looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
f69841cbc9faee3dc4fd110e4fc75a5404e3b21c de80e42988628fb687e5be3c3d86bbe700a5cb94

Is this intentional?

Copy link
Contributor

@damian-kaczmarek looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
f69841cbc9faee3dc4fd110e4fc75a5404e3b21c 3c4f4e1ea70bbf76a00f31085b3460fbbf102ceb

Is this intentional?

Copy link
Contributor

@damian-kaczmarek looks like you are rolling back kalium to a previous commitish.

This means that the PR's target branch (develop) is using a newer version of Kalium, and the changes in this PR will rollback Kalium to an older version.

develop This PR
f69841cbc9faee3dc4fd110e4fc75a5404e3b21c 63ea6a96000ff9fe562ca4b910db6c05d5d96a7f

Is this intentional?

Copy link

sonarcloud bot commented Nov 14, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 45.97%. Comparing base (fcb871e) to head (3203e31).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...serprofile/teammigration/TeamMigrationViewModel.kt 14.28% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3625      +/-   ##
===========================================
- Coverage    45.99%   45.97%   -0.02%     
===========================================
  Files          473      473              
  Lines        16064    16088      +24     
  Branches      2659     2662       +3     
===========================================
+ Hits          7389     7397       +8     
- Misses        7896     7910      +14     
- Partials       779      781       +2     
Files with missing lines Coverage Δ
...ui/userprofile/teammigration/TeamMigrationState.kt 100.00% <100.00%> (ø)
...serprofile/teammigration/TeamMigrationViewModel.kt 67.56% <14.28%> (-32.44%) ⬇️

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcb871e...3203e31. Read the comment docs.

Copy link
Contributor

Built wire-android-staging-compat-pr-3625.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3625.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants