Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to start minimized #146

Closed
wants to merge 10 commits into from
Closed

Add option to start minimized #146

wants to merge 10 commits into from

Conversation

ConorIA
Copy link
Contributor

@ConorIA ConorIA commented Nov 3, 2016

Adds a checkbox to the 'Window' menu to start the app in the tray (i.e. skip main.show() on startup.)
This partially addresses #104.

I'm not sure what is going on in the Windows menu, so I didn't touch that, but I feel pretty confident about the code for macOS. Tried, tested and true on Linux, of course!

@shvchk
Copy link

shvchk commented Nov 4, 2016

Would be nice to also have this as an argument, like --minimized, so that Wire could be added to autostart to be launched minimized, and showed as usual if launched manually.

For now I'm using this script in autostart (on Linux) to start Wire minimized.

@ConorIA
Copy link
Contributor Author

ConorIA commented Nov 4, 2016

I'm not entirely sure what the --startup flag is for, but if it is true, I think the app window won't show. It is on the same line as the change I made in this PR. @lipis, is this used anywhere else in the app?

@ConorIA
Copy link
Contributor Author

ConorIA commented Nov 4, 2016

Come to think of it, my guess is that that flag is precisely for when you want Wire to launch on startup. 😌

@shvchk
Copy link

shvchk commented Nov 4, 2016

Ha! There really is if (!argv.startup) check before main.show(), thanks for the tip!

P.S. Then maybe it would be more clear to have both option and argument checked at once, like if (!argv.startup && !startInTray) instead of the second if (!startInTray) check?

@ConorIA
Copy link
Contributor Author

ConorIA commented Nov 5, 2016

Thanks for the suggestion. It's addressed in the last couple of commits.

@ConorIA
Copy link
Contributor Author

ConorIA commented Dec 19, 2016

Updated to include newer changes.

@ConorIA ConorIA mentioned this pull request Dec 20, 2016
@lipis
Copy link
Contributor

lipis commented Jan 19, 2017

Handled in #329

@lipis lipis closed this Jan 19, 2017
@ConorIA ConorIA deleted the startMini branch January 19, 2017 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants