Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

支持嵌套 namespace 非全量 bucket 实验 #32

Merged
merged 1 commit into from
May 28, 2024
Merged

支持嵌套 namespace 非全量 bucket 实验 #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions outplan/experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,9 @@ def get_group(self, unit="", **params): # noqa: PLR0912
# 直到取到最底层分组
while True:
_res = group_item.get_group(unit, **params)
# 没有通过 bucket 匹配到实验
if _res is None:
return None
if isinstance(_res, TrackingGroup):
for group_name, exp_name in zip(group_names, exp_names):
_res.add_group_name(group_name)
Expand Down
161 changes: 161 additions & 0 deletions tests/test_experiment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -696,6 +696,167 @@ def test_not_full_bucket_namespace_get_group():
assert cnt <= 10


def test_nested_not_full_experiment_group_client():
"""
测试实验组嵌套子namespace，并且子 namespace 中实验 bucket 不满的情况
"""
namespace_spec = {
"name": "test_namespace_exp2",
"bucket": 100,
"unit_type": "pdid",
"auto_upper_unit": True,
"experiment_items": [
{
"name": "ttt111",
"bucket": 50,
"pre_condition": "",
"group_items": [
{
"name": "ns1",
"weight": 0.33,
"extra_params": "",
"layer_namespaces": [
{
"name": "nested_ns1",
"bucket": 100,
"unit_type": "pdid",
"auto_upper_unit": True,
"experiment_items": [
{
"name": "nested_test_1",
"bucket": 10,
"pre_condition": "",
"group_items": [
{
"name": "exp1",
"weight": 0.5,
"extra_params": "",
"layer_namespaces": [],
},
{
"name": "control1",
"weight": 0.5,
"extra_params": "",
"layer_namespaces": [],
},
],
"user_tags": [],
}
],
}
],
},
{
"name": "ns2",
"weight": 0.34,
"extra_params": "",
"layer_namespaces": [
{
"name": "nested_test_ns2",
"bucket": 100,
"unit_type": "pdid",
"auto_upper_unit": True,
"experiment_items": [
{
"name": "nested_test_0528_2",
"bucket": 20,
"pre_condition": "",
"group_items": [
{
"name": "exp2",
"weight": 0.5,
"extra_params": "",
"layer_namespaces": [],
},
{
"name": "control2",
"weight": 0.5,
"extra_params": "",
"layer_namespaces": [],
},
],
"user_tags": [],
}
],
}
],
},
{
"name": "ns3",
"weight": 0.33,
"extra_params": "",
"layer_namespaces": [
{
"name": "test_nested_0528_3",
"bucket": 100,
"unit_type": "pdid",
"auto_upper_unit": True,
"experiment_items": [
{
"name": "test_nested_0528_3",
"bucket": 30,
"pre_condition": "",
"group_items": [
{
"name": "exp3",
"weight": 0.5,
"extra_params": "",
"layer_namespaces": [],
},
{
"name": "control3",
"weight": 0.5,
"extra_params": "",
"layer_namespaces": [],
},
],
"user_tags": [],
}
],
}
],
},
],
"user_tags": [],
},
{
"name": "test_nest_0528_4",
"bucket": 50,
"pre_condition": "",
"group_items": [
{
"name": "a",
"weight": 0.5,
"extra_params": "",
"layer_namespaces": [],
},
{
"name": "control",
"weight": 0.5,
"extra_params": "",
"layer_namespaces": [],
},
],
"user_tags": [],
},
],
}
namespace = NamespaceItem.from_dict(namespace_spec)
namespace.validate()

for i in range(1000):
namespace.get_group(unit=f"foo-{i}")

expected = ['a', None, 'control', 'a', None, 'control', 'a', None, 'a', 'control', 'exp1', 'control3', 'control', None, 'control3', None, 'exp3', 'a', None, None]

for i in range(20):
res = namespace.get_group(unit=f"foo-{i}")
if res:
assert res.last_group == expected[i]
else:
assert expected[i] is None


def test_auto_upper_unit_namespace():
def same_group(group_a, group_b):
if group_a is None and group_b is None:
Expand Down
Loading