chore: updates to periphery #93
Annotations
1 error and 14 warnings
commits
You have commit messages with errors
⧗ input: forge install: tokenized-strategy-periphery
6ce8d29b1e107a89754dd9f17337582734989b4d
✖ subject may not be empty [subject-empty]
✖ type may not be empty [type-empty]
✖ found 2 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
⧗ input: forge install: tokenized-strategy
v3.0.2-1
✖ subject may not be empty [subject-empty]
✖ type may not be empty [type-empty]
✖ found 2 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
|
commits
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
solidity
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-node@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
solidity
The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3, actions/setup-node@v1, actions/cache@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
solidity:
src/interfaces/IStrategyInterface.sol#L6
Code contains empty blocks
|
solidity:
src/periphery/StrategyAprOracle.sol#L29
Variable "_strategy" is unused
|
solidity:
src/periphery/StrategyAprOracle.sol#L30
Variable "_delta" is unused
|
solidity:
src/Strategy.sol#L46
Code contains empty blocks
|
solidity:
src/Strategy.sol#L73
Code contains empty blocks
|
solidity:
src/test/FunctionSignature.t.sol#L4
global import of path forge-std/console2.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
solidity:
src/test/FunctionSignature.t.sol#L5
imported name IStrategyInterface is not used
|
solidity:
src/test/FunctionSignature.t.sol#L15
Function body contains 76 lines but allowed no more than 50 lines
|
solidity:
src/test/FunctionSignature.t.sol#L15
Function name must be in mixedCase
|
solidity:
src/test/Operation.t.sol#L4
global import of path forge-std/console2.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
solidity
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|