Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add variable scaling factor to redemption curve #230

Merged
merged 10 commits into from
Oct 17, 2023
Merged

feat: add variable scaling factor to redemption curve #230

merged 10 commits into from
Oct 17, 2023

Conversation

0xkorin
Copy link
Collaborator

@0xkorin 0xkorin commented Oct 9, 2023

  • Add variable scaling factor
  • oYFI -> dYFI, Option -> Redemption

Schlagonia
Schlagonia reviewed Oct 10, 2023
View reviewed changes
contracts/Redemption.vy Outdated Show resolved Hide resolved
contracts/Redemption.vy Outdated Show resolved Hide resolved
contracts/Redemption.vy Outdated Show resolved Hide resolved
contracts/Redemption.vy Outdated Show resolved Hide resolved
contracts/Redemption.vy Show resolved Hide resolved
contracts/Redemption.vy Outdated Show resolved Hide resolved
contracts/Redemption.vy Outdated Show resolved Hide resolved
contracts/Redemption.vy Outdated Show resolved Hide resolved
contracts/Redemption.vy Show resolved Hide resolved
Schlagonia
Schlagonia suggested changes Oct 10, 2023
View reviewed changes
Copy link

@Schlagonia Schlagonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to the changes, and correct me if I'm missing something.

But it appears we are using immutable variables in multiple places in the Gauge.sol here and the BaseGauge.sol here which will not get set correctly if we use the GaugeFactory that clones them

@0xkorin
Copy link
Collaborator Author

0xkorin commented Oct 11, 2023

Thanks for the review. Indeed the factory is broken and untested, we do not plan to use it at launch.

Schlagonia
Schlagonia approved these changes Oct 11, 2023
View reviewed changes
Copy link

@Schlagonia Schlagonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

storming0x
storming0x reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@storming0x storming0x left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some minor comments to ack mainly on first review

storming0x
storming0x reviewed Oct 16, 2023
View reviewed changes
contracts/Redemption.vy Outdated Show resolved Hide resolved
@storming0x
Copy link
Contributor

latest changes LGTM

storming0x
storming0x approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@storming0x storming0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

latest changes LGTM!

@0xkorin 0xkorin merged commit d30ab01 into yearn:master Oct 17, 2023
4 checks passed
@rareweasel rareweasel mentioned this pull request Oct 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Schlagonia Schlagonia Schlagonia approved these changes

@storming0x storming0x storming0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xkorin @storming0x @Schlagonia