Add Filter and Sorting for Progress Reports #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit e668c6c): https://roar-staging--pr386-enh-progress-filter-7gtgqnmt.web.app (expires Tue, 12 Mar 2024 23:13:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
1 flaky test on run #405 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Testing playthrough of SWR as a participant > ROAR-Word Playthrough Test |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #386 ↗︎
lucasxsong
force-pushed
the
enh/progress-filter-sort
branch
4 times, most recently
from
494f1ad
to
5e76647
Compare
richford
changed the title
lucasxsong
force-pushed
the
enh/progress-filter-sort
branch
from
91806f3
to
f27c472
Compare
lucasxsong
changed the title
lucasxsong
force-pushed
the
enh/progress-filter-sort
branch
2 times, most recently
from
b5632ea
to
622da38
Compare
kellyel
approved these changes
Mar 5, 2024
lucasxsong
force-pushed
the
enh/progress-filter-sort
branch
from
2051622
to
e668c6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds sorting and filtering to the progress report. The current iteration supports sorting and filtering on most categories in the table, as well as sorting by grade and school.
One caveat is that filtering by completion status is currently limited to only
CompletedandStarted. This is because the filtering mechanism is built on the scores collection, where non-completed and non-started assignments will have no entry. I tried to implement the filtering mechanism based on the assessments collection, but ran into some road blocks (at least from what I tried) in being unable to query within the nested arrayassignments. You can see the prototype code here.