-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate TanStack queries to query composables #748
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit 368a986): https://roar-staging--pr748-ref-318-query-compos-licip3pp.web.app (expires Tue, 22 Oct 2024 22:12:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
roar-dashboard-e2e Run #8431
Run Properties:
|
Project |
roar-dashboard-e2e
|
Run status |
Passed #8431
|
Run duration | 03m 28s |
Commit |
368a98652e: E2E Tests for PR 748 "`CU-8689c0g67` Migrate TanStack queries to query composabl...
|
Committer | Adam Richie-Halford |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
14
|
maximilianoertel
force-pushed
the
ref/318/query-composables
branch
from
August 22, 2024 17:04
f685446
to
21daca8
Compare
21 tasks
21 tasks
…sable Extend `useUserType` with super admin capability check
Resolve merge conflicts for TanStack composables
* Fix SWR task loading * Fix Vocab task loading * Fix SRE task loading * Fix Ran task loading * Fix PA task loading * Fix Multichoice task loading * Fix MEP task loading * Fix Levante task loading * Fix Letter task loading * Fix Fluency task loading * Fix Crowding task loading
…es-admin-selection
…in-selection Fix administration selection
* Fix flashing loading states on participant homepage * Fix refs
richford
approved these changes
Oct 15, 2024
Emily-ejag
approved these changes
Oct 15, 2024
kellyel
approved these changes
Oct 15, 2024
maximilianoertel
changed the title
Migrate TanStack queries to query composables
Oct 15, 2024
CU-8689c0g67
Migrate TanStack queries to query composables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR migrates the existing TanStack queries defined throughout the codebase to re-usable query composables.
Caution
Due to the extent of the changes, this PR should be heavily tested on the ephemeral environment before merging.
Key Highlights:
Additional Notes
package-lock
file due to build failures in the CI caused by npm/cli#4828.@tanstack/vue-query
to the latest version, which introduces some deprecations.cacheTime
) and stale time.getAxiosInstance
helper with abaseUrl
check to ensure it is always set, addressing an issue that appears to stem from the initialization process.useDistrictsQuery
composable to enable data caching and reuse.<HomeSelector />
component now lazy loads the homepage and consent modal components.Chained Pull Requests:
<HomeSelector>
race condition #751ClassLink
andClever
into single refactored SSO landing page #837fetchDocById
helper #867Types of changes
Checklist
Justification of missing checklist items
n/a
Further comments
n/a
Resolves https://github.com/yeatmanlab/roar/issues/318
Resolves https://github.com/yeatmanlab/roar/issues/376