-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Score Reports Not Populating Correctly #895
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksmontville
force-pushed
the
fix/453-populate-score-reports
branch
from
October 17, 2024 20:16
1d5f12d
to
acf5df4
Compare
ksmontville
added
bug
Something isn't working
urgency: high
This issue needs to be resolved this week
impact: medium
Medium impact on the project as a whole
labels
Oct 17, 2024
Visit the preview URL for this PR (updated for commit 990af37): https://roar-staging--pr895-fix-453-populate-sco-2npbldb1.web.app (expires Fri, 25 Oct 2024 17:29:57 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
roar-dashboard-e2e Run #8520
Run Properties:
|
Project |
roar-dashboard-e2e
|
Run status |
Passed #8520
|
Run duration | 01m 49s |
Commit |
990af37dcf: Component Tests for PR 895 "Fix Score Reports Not Populating Correctly" from com...
|
Committer | Kyle |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
1
|
Passing |
4
|
richford
requested changes
Oct 17, 2024
… refreshing the page
ksmontville
force-pushed
the
fix/453-populate-score-reports
branch
from
October 18, 2024 17:25
d00bb14
to
990af37
Compare
Emily-ejag
approved these changes
Oct 21, 2024
richford
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
impact: medium
Medium impact on the project as a whole
urgency: high
This issue needs to be resolved this week
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This pull request addresses https://github.com/yeatmanlab/roar/issues/453.
Major Changes:
schoolOptions
, re-enabling filtering by schoolTypes of changes
What types of changes does this pull request introduce?
Checklist
Justification of missing checklist items
Further comments