Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Score Reports Not Populating Correctly #895

Merged
merged 7 commits into from
Oct 21, 2024

Conversation

ksmontville
Copy link
Collaborator

@ksmontville ksmontville commented Oct 17, 2024

Proposed changes

This pull request addresses https://github.com/yeatmanlab/roar/issues/453.

Major Changes:

  1. Created a computed property for schoolOptions, re-enabling filtering by school
  2. Fix grade level filtering by casting user grade as a string for comparison (was previously failing due to type difference)
  3. Update composable logic to better capture and use the initial state of the data table
  4. Update watchers to trigger immediately (this resolves the issue with data not being populated after navigating away, and then back to, the score report)

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@ksmontville ksmontville requested a review from a team as a code owner October 17, 2024 20:15
Copy link

github-actions bot commented Oct 17, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 5.07% 390 / 7687
🔵 Statements 4.97% 421 / 8462
🔵 Functions 6.09% 115 / 1888
🔵 Branches 2.41% 110 / 4552
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/composables/useFilteredTableData.js 0% 0% 0% 0% 5-8, 7, 30, 32-43, 33, 35-37, 36, 36, 38-40, 39, 39, 42, 45-50, 46-48, 47, 49, 52
src/pages/HomeSelector.vue 0% 0% 0% 0% 37, 37-38, 38-39, 39, 41-43, 45-46, 48, 50-53, 51-52, 55-56, 58, 60-63, 61, 61-62, 65-67, 66, 66, 69-71, 73-75, 77, 79, 79-85, 84, 87-94, 89-93, 90, 92, 96-97, 100, 104, 104, 106-107, 109, 111-115, 112-114, 117-118, 118, 120-123, 121-122, 127-129, 132-140, 135-137, 136, 142-148, 143-146, 144-145, 147, 147, 1, 3, 5
src/pages/ScoreReport.vue 0% 0% 0% 0% 355, 312-314, 316, 331, 333-338, 334-336, 335, 337, 340-344, 346-349, 347-348, 351, 353, 356, 356, 358-407, 359-361, 364-367, 366, 370, 372-391, 373-374, 374, 377-378, 380-383, 382, 385-387, 386, 388-390, 389, 394-397, 396, 398-404, 406, 409-418, 420-425, 421-424, 427, 429-431, 433-435, 437, 439-442, 441, 444-446, 448-451, 450, 457-459, 461-468, 462-467, 464-465, 470-477, 471-476, 473-474, 479-481, 480, 480, 485-516, 486-515, 487-515, 489-515, 491-515, 493-515, 498-504, 503, 505-515, 507-512, 509, 511, 513-515, 514, 517, 520-564, 532-535, 537-551, 542-548, 543-544, 546-547, 550, 553, 553-554, 554, 556-563, 566-586, 567, 567-585, 569-580, 570-576, 578-579, 581-584, 591-845, 592-844, 593, 596, 598, 600-809, 602, 606-611, 610, 613-615, 617, 619-639, 641-802, 645-652, 649, 651, 653-657, 654, 656, 659-666, 660-666, 663, 665, 668-670, 669, 673, 676-685, 687-693, 688-693, 690-693, 692, 695, 698-709, 711-745, 712-745, 721-722, 724-745, 733, 735-744, 746-764, 747-757, 755, 758, 760-763, 765-778, 766-770, 770-771, 771-772, 772-777, 781-795, 797-801, 798, 800, 805-806, 808, 812-837, 813-816, 815, 818-821, 820, 823-833, 825-830, 829, 831-833, 832, 835-836, 839-841, 840, 843, 848-849, 851-857, 854, 859, 861-866, 892-993, 893-990, 894-900, 902-904, 903, 906-908, 907, 910-987, 911-912, 915-933, 916-933, 920-933, 924-933, 927, 929-932, 936-953, 937-950, 939-947, 940-942, 941, 943-944, 946, 949, 952, 956-986, 957, 957, 959-985, 960-974, 961, 964-973, 965, 968-972, 969, 971, 977-984, 978, 981-983, 982, 989, 992, 1002-1060, 1003-1004, 1007-1012, 1009-1011, 1010, 1015, 1018, 1021-1025, 1023, 1023, 1028-1040, 1031-1033, 1032, 1034-1036, 1035, 1037, 1037-1038, 1043-1049, 1044-1047, 1046, 1048, 1052-1056, 1059, 1063-1064, 1067, 1069-1107, 1070-1076, 1078-1084, 1080-1083, 1081-1082, 1086, 1086, 1088-1089, 1091-1092, 1092, 1094-1105, 1095-1105, 1102-1105, 1104, 1106, 1111-1300, 1112, 1112-1137, 1127-1136, 1138-1147, 1138-1146, 1148-1161, 1148-1160, 1150-1157, 1159, 1162-1164, 1162-1163, 1166, 1168-1179, 1169-1178, 1181-1189, 1182-1188, 1191-1197, 1192-1196, 1193, 1195, 1199-1205, 1208-1214, 1209-1213, 1210-1212, 1211, 1217-1222, 1225-1229, 1226-1228, 1227, 1231-1298, 1233, 1236-1264, 1237-1264, 1244-1264, 1251, 1253-1263, 1254-1263, 1256-1263, 1258-1263, 1260, 1262, 1266, 1268-1278, 1275, 1277, 1280-1297, 1292-1294, 1293, 1295, 1299, 1302-1306, 1303-1305, 1304, 1304-1305, 1308-1319, 1309-1310, 1310-1311, 1311, 1313-1315, 1314, 1317-1318, 1321-1325, 1322-1324, 1323, 1328-1334, 1329-1330, 1330, 1332-1333, 1336-1338, 1337, 1337, 1340-1345, 1341-1344, 1344, 2-3, 8, 12-13, 15-16, 21-22, 27, 29, 63, 66-67, 69, 78-79, 82, 96-97, 103, 109, 116, 125, 1, 145, 158, 164, 170, 176, 193, 245-246, 1-31, 48, 138-139, 1-148
Generated in workflow #761 for commit 990af37 by the Vitest Coverage Report Action

@ksmontville ksmontville added bug Something isn't working urgency: high This issue needs to be resolved this week impact: medium Medium impact on the project as a whole labels Oct 17, 2024
@ksmontville ksmontville self-assigned this Oct 17, 2024
Copy link

github-actions bot commented Oct 17, 2024

Visit the preview URL for this PR (updated for commit 990af37):

https://roar-staging--pr895-fix-453-populate-sco-2npbldb1.web.app

(expires Fri, 25 Oct 2024 17:29:57 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Oct 17, 2024

roar-dashboard-e2e    Run #8520

Run Properties:  status check passed Passed #8520  •  git commit 990af37dcf: Component Tests for PR 895 "Fix Score Reports Not Populating Correctly" from com...
Project roar-dashboard-e2e
Run status status check passed Passed #8520
Run duration 01m 49s
Commit git commit 990af37dcf: Component Tests for PR 895 "Fix Score Reports Not Populating Correctly" from com...
Committer Kyle
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 1
Tests that passed  Passing 4

src/pages/ScoreReport.vue Outdated Show resolved Hide resolved
src/composables/useFilteredTableData.js Outdated Show resolved Hide resolved
@ksmontville ksmontville requested review from richford and a team October 18, 2024 17:25
@richford richford merged commit 85ed2bc into main Oct 21, 2024
24 checks passed
@richford richford deleted the fix/453-populate-score-reports branch October 21, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working impact: medium Medium impact on the project as a whole urgency: high This issue needs to be resolved this week
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants