-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce vue/no-undef-components
ESLint rule
#921
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
Coverage Report
File Coverage
|
Visit the preview URL for this PR (updated for commit be81933): https://roar-staging--pr921-fix-eslint-component-88mj31cn.web.app (expires Wed, 06 Nov 2024 21:42:13 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
roar-dashboard-e2e Run #8791
Run Properties:
|
Project |
roar-dashboard-e2e
|
Branch Review |
fix/eslint-component-rule
|
Run status |
Passed #8791
|
Run duration | 02m 04s |
Commit |
be819335d6: Component Tests for PR 921 "Enforce `vue/no-undef-components` ESLint rule" from ...
|
Committer | Maximilian Oertel |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
17
|
View all changes introduced in this branch ↗︎ |
ksmontville
previously approved these changes
Oct 30, 2024
lucasxsong
previously approved these changes
Oct 30, 2024
Emily-ejag
dismissed stale reviews from lucasxsong and ksmontville
October 30, 2024 21:01
The base branch was changed.
Emily-ejag
approved these changes
Oct 30, 2024
kellyel
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR enforces the optional (yet essential) ESLint rule
vue/no-undef-components
to ensure we catch undefined components as part of our linter checks. This PR also updates theeslint-plugin-vue
package to its latest version.Types of changes
Checklist
Justification of missing checklist items
n/a
Further comments
n/a