Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce vue/no-undef-components ESLint rule #921

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

maximilianoertel
Copy link
Collaborator

@maximilianoertel maximilianoertel commented Oct 30, 2024

Proposed changes

This PR enforces the optional (yet essential) ESLint rule vue/no-undef-components to ensure we catch undefined components as part of our linter checks. This PR also updates the eslint-plugin-vue package to its latest version.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

n/a

Further comments

n/a

Copy link

github-actions bot commented Oct 30, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 5.11% 390 / 7619
🔵 Statements 5.01% 421 / 8392
🔵 Functions 6.12% 115 / 1879
🔵 Branches 2.41% 110 / 4552
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/pages/LEVANTE/UserSurvey.vue 0% 0% 0% 0% 17-33, 18-31, 22-30, 23-28, 27, 29, 32, 35-48, 50, 53, 57-58, 62-73, 64-66, 65, 67-70, 69, 72, 76-78, 77, 80-86, 81-85, 82-84, 89-90, 90, 92-128, 93-96, 98, 100, 102, 104-113, 107, 109-110, 112, 115-125, 117-120, 119, 121-124, 122-123, 127, 132-142, 133, 135, 137-139, 138, 140, 145-148, 147, 149-153, 157, 160-167, 161, 163-166, 170, 174-192, 175-176, 179, 182-183, 185-191, 1, 207
Generated in workflow #821 for commit be81933 by the Vitest Coverage Report Action

@maximilianoertel maximilianoertel self-assigned this Oct 30, 2024
@maximilianoertel maximilianoertel added the enhancement New feature or request label Oct 30, 2024
Copy link

github-actions bot commented Oct 30, 2024

Visit the preview URL for this PR (updated for commit be81933):

https://roar-staging--pr921-fix-eslint-component-88mj31cn.web.app

(expires Wed, 06 Nov 2024 21:42:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Oct 30, 2024

roar-dashboard-e2e    Run #8791

Run Properties:  status check passed Passed #8791  •  git commit be819335d6: Component Tests for PR 921 "Enforce `vue/no-undef-components` ESLint rule" from ...
Project roar-dashboard-e2e
Branch Review fix/eslint-component-rule
Run status status check passed Passed #8791
Run duration 02m 04s
Commit git commit be819335d6: Component Tests for PR 921 "Enforce `vue/no-undef-components` ESLint rule" from ...
Committer Maximilian Oertel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 17
View all changes introduced in this branch ↗︎

ksmontville
ksmontville previously approved these changes Oct 30, 2024
lucasxsong
lucasxsong previously approved these changes Oct 30, 2024
Base automatically changed from fix/donut-chart to main October 30, 2024 21:01
@Emily-ejag Emily-ejag dismissed stale reviews from lucasxsong and ksmontville October 30, 2024 21:01

The base branch was changed.

@maximilianoertel maximilianoertel merged commit fdaafe0 into main Oct 30, 2024
24 checks passed
@maximilianoertel maximilianoertel deleted the fix/eslint-component-rule branch October 30, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants