Make authManger() in UserPanel configurable. #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h another components ID name instead default authManager.
bizley
reviewed
Aug 11, 2021
bizley
reviewed
Aug 11, 2021
src/panels/UserPanel.php
Outdated
| @@ -235,7 +236,8 @@ public function save() | |||
| $permissionsProvider = null; | |||
|
|
|||
| try { | |||
| $authManager = Yii::$app->getAuthManager(); | |||
|
|
|||
| $authManager = Instance::ensure($this->module->authManager, \yii\rbac\BaseManager::class); | |||
There was a problem hiding this comment.
I would not add hard requirement for this, we don't have it currently. This logic must be improved, not sure if we should allow building component here, maybe just to take already built one from the main app? (Something to discuss).
jafaripur
commented
Aug 11, 2021
Co-authored-by: Bizley <pawel@positive.codes>
|
@jafaripur would you please add a line for CHANGELOG? |
Yes, I think this is good idea. |
bizley
reviewed
Aug 11, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make authManager configurable for user panel when application use another components id instread default authManager.