-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs to properly limit variable size #1074
base: main
Are you sure you want to change the base?
Conversation
Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @graphite on file. In order for us to review and merge your code, please sign:
If you already signed one of this document, just wait to be added to the bot config. |
What do you think @aPere3 |
@graphite could you please sign again the CLA, some fields were missing, I have just updated the template to make it clearer |
I signed it right away, please check |
Yes, I see it but as mentioned, all fields are blank except your signature, that's why I was asking if you could fill it again? |
I had to go through incognito and use a different email, otherwise it did not allow filling the other fields at all. Please check now. |
@cla-bot check |
The cla-bot has been summoned, and re-checked this pull request! |
Sorry for that, I had to tweak the template and as you already have filled it, it was not a normal situation. But everything is ok now, thanks a lot 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch @graphite ! Thanks for the PR !
Combined with
inputset = list(range(20))
below current example leads to bugs due to the expression evaluation order