Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs to properly limit variable size #1074

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

graphite
Copy link

Combined with inputset = list(range(20)) below current example leads to bugs due to the expression evaluation order

Copy link

cla-bot bot commented Sep 29, 2024

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @graphite on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

@bcm-at-zama
Copy link
Contributor

What do you think @aPere3

@aPere3 aPere3 self-requested a review October 1, 2024 07:18
@aquint-zama
Copy link
Contributor

@graphite could you please sign again the CLA, some fields were missing, I have just updated the template to make it clearer

@graphite
Copy link
Author

graphite commented Oct 1, 2024

I signed it right away, please check

@aquint-zama
Copy link
Contributor

I signed it right away, please check

Yes, I see it but as mentioned, all fields are blank except your signature, that's why I was asking if you could fill it again?

@graphite
Copy link
Author

graphite commented Oct 1, 2024

I had to go through incognito and use a different email, otherwise it did not allow filling the other fields at all. Please check now.

@aquint-zama
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Oct 1, 2024
Copy link

cla-bot bot commented Oct 1, 2024

The cla-bot has been summoned, and re-checked this pull request!

@aquint-zama
Copy link
Contributor

Sorry for that, I had to tweak the template and as you already have filled it, it was not a normal situation. But everything is ok now, thanks a lot 🙏

Copy link
Collaborator

@aPere3 aPere3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @graphite ! Thanks for the PR !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants