Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small corrections to ctrl-c behavior, tracing #74

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

litlep-nibbyt
Copy link
Contributor

@litlep-nibbyt litlep-nibbyt commented Nov 13, 2024

  • change snapshot not-changed message to trace logging level since it dominates the debug logs.
  • ctrl-c now exits the process immediately without waiting. The rationale being that the user should be able to exit the app without waiting for nock processing to finish in the current event. I left the cancellation token inside of NockApp because we still want a way to gracefully shutdown the app from within the work() function.

@eamsden eamsden merged commit 8279e6a into master Nov 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants