-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload test results in CI when there are failing tests #3322
Draft
t1m0thyj
wants to merge
5
commits into
main
Choose a base branch
from
ci/always-upload-test-results
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3322 +/- ##
=======================================
Coverage 92.99% 92.99%
=======================================
Files 116 116
Lines 12069 12069
Branches 2738 2781 +43
=======================================
Hits 11224 11224
Misses 843 843
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
t1m0thyj
added
the
no-changelog
Add to PR's that don't require a CHANGELOG update
label
Nov 15, 2024
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
t1m0thyj
requested review from
traeok,
awharn,
zFernand0,
JillieBeanSim,
likhithanimma1 and
SanthoshiBoyina1
November 15, 2024 20:34
📅 Suggested merge-by date: 11/29/2024 |
There is another integration test ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This is useful for debugging integration tests since we can download screenshots of failing tests 😋
Also hopefully fixes transient errors on the
ShowConfigErrorDialog
test - since sometimes notifications are hidden in the notification center and other times they are still visible, it seems like we need to check both places.Release Notes
Milestone: N/A
Changelog: N/A
Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments