Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ZE Theia workflow #12

Merged
merged 5 commits into from
Jun 21, 2024
Merged

Fix ZE Theia workflow #12

merged 5 commits into from
Jun 21, 2024

Conversation

t1m0thyj
Copy link
Member

The workflow was failing to build because Theia does not yet support building with Python 3.12: eclipse-theia/theia#13008

Also updated logic for passing Theia versions as input to the workflow, since Theia no longer labels community releases as such in their GitHub release notes.

The new workflow input looks like this:
image

Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @t1m0thyj!

.github/workflows/ze-theia-slim.yaml Outdated Show resolved Hide resolved
Co-authored-by: Trae Yelovich <trae.yelovich@broadcom.com>
Signed-off-by: Timothy Johnson <timothy.johnson@broadcom.com>
@t1m0thyj t1m0thyj merged commit 1cb76e8 into main Jun 21, 2024
3 checks passed
@t1m0thyj t1m0thyj deleted the build/theia-docker-1.49 branch June 21, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants