Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused channel config parameter #150

Merged

Conversation

anton-seaice
Copy link
Contributor

@anton-seaice anton-seaice commented Nov 12, 2024

Unset Channel_config per COSIMA/access-om3#233

@anton-seaice
Copy link
Contributor Author

!test repro

Copy link

✅ The Bitwise Reproducibility Check Succeeded ✅

When comparing:

  • 233-1deg_jra55do_ryf-channel-config (checksums created using commit 9275c5b), against
  • dev-1deg_jra55do_ryf (checksums in commit 01cbd6f)
Further information

The experiment can be found on Gadi at /scratch/tm70/repro-ci/experiments/access-om3-configs/9275c5b132f88d9144f1f313113cfdff3b0a4273, and the test results at .

The checksums generated by this !test command are found in the testing/checksum directory of https://github.com/ACCESS-NRI/access-om3-configs/actions/runs/11788394721/artifacts/2173853149.

The checksums compared against are found here https://github.com/ACCESS-NRI/access-om3-configs/tree/01cbd6fceb970ab79ee82490df3d4bf8d41447e8/testing/checksum

@access-hive-bot
Copy link

This pull request has been mentioned on ACCESS Hive Community Forum. There might be relevant details there:

https://forum.access-hive.org.au/t/ocean-team-workshop-12-15th-november-2024/3857/7

@anton-seaice anton-seaice changed the title Update MOM_input Remove unused channel config parameter Nov 17, 2024
@anton-seaice
Copy link
Contributor Author

@minghangli-uni - can you review? We can merge this

@anton-seaice anton-seaice merged commit 38c039f into dev-1deg_jra55do_ryf Nov 19, 2024
15 of 16 checks passed
@anton-seaice anton-seaice deleted the 233-1deg_jra55do_ryf-channel-config branch November 19, 2024 04:26
@anton-seaice
Copy link
Contributor Author

! cherry-pick 38c039f into dev-1deg_jra55do_iaf

@anton-seaice
Copy link
Contributor Author

!cherry-pick 38c039f into dev-1deg_jra55do_iaf

Copy link

Automatic Git cherry-picking of commit(s) 38c039f into dev-1deg_jra55do_iaf failed. This usually happens when cherry-picking results in a conflic or an empty commit. To manually cherry-pick the commits and open a pull request, please follow these instructions:

  1. Create new branch from target branch:
git checkout dev-1deg_jra55do_iaf
git pull
git checkout -b cherry_pick_from_pr150_into_dev-1deg_jra55do_iaf
  1. Cherry-pick commits:
git cherry-pick 38c039f4b87e6394ff54adde1986686195bb12e3
  1. Fix any conflicts and/or empty commits by following the instructions provided by Git.
  2. Push the new branch:
git push --set-upstream origin cherry_pick_from_pr150_into_dev-1deg_jra55do_iaf
  1. Open a new pull request on github making sure the target branch is set to dev-1deg_jra55do_iaf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants