Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Party base sync #1033

Open
wants to merge 10 commits into
base: development
Choose a base branch
from
Open

Party base sync #1033

wants to merge 10 commits into from

Conversation

EgardA
Copy link
Contributor

@EgardA EgardA commented Nov 15, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • All new classes have class-level documentation comments, if there are any at all
  • Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation update
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Resolves #

Other information

@EgardA
Squashed commit of the following:
71348d7 
commit e82ecb5
Author: Alexander Egard <veryhasted@gmail.com>
Date:   Wed Oct 23 21:28:01 2024 +0200

    More lifetimes, test passes

commit bc8b998
Author: Alexander Egard <veryhasted@gmail.com>
Date:   Tue Oct 22 00:29:53 2024 +0200

    Update CultureObjectRegistry.cs

commit 0a821cc
Merge: f9970f0 3233dbe
Author: Alexander Egard <veryhasted@gmail.com>
Date:   Tue Oct 22 00:00:29 2024 +0200

    Merge branch 'development' into SettlementFields

commit f9970f0
Author: Alexander Egard <veryhasted@gmail.com>
Date:   Fri Oct 11 13:29:30 2024 +0200

    Update GameObjectCreator.cs

commit 7ce6410
Merge: 23480be baeef2b
Author: Alexander Egard <veryhasted@gmail.com>
Date:   Fri Oct 11 13:29:09 2024 +0200

    Merge branch 'development' into SettlementFields

commit 23480be
Author: EgardA <veryhasted@gmail.com>
Date:   Wed Sep 25 22:59:21 2024 +0200

    some test stuff

commit f65e5e8
Merge: d436c25 8545df8
Author: EgardA <veryhasted@gmail.com>
Date:   Wed Sep 25 21:02:49 2024 +0200

    Merge branch 'development' into SettlementFields

commit d436c25
Merge: 08e1653 e18f320
Author: EgardA <veryhasted@gmail.com>
Date:   Wed Sep 25 20:39:57 2024 +0200

    Merge branch 'development' into SettlementFields

commit 08e1653
Author: EgardA <veryhasted@gmail.com>
Date:   Tue Sep 24 15:57:39 2024 +0200

    Who knows

commit 4f00d47
Author: EgardA <veryhasted@gmail.com>
Date:   Mon Sep 23 15:07:32 2024 +0200

    TextObject Surrogate

commit 5b5376d
Author: Garrett Luskey <garrett.luskey@gmail.com>
Date:   Sun Sep 22 17:44:07 2024 -0500

    Update SurrogateCollection.cs

commit 65874a7
Merge: a59798f 14b5ace
Author: Garrett Luskey <garrett.luskey@gmail.com>
Date:   Sun Sep 22 17:25:05 2024 -0500

    Merge branch 'autosync-bug-fix' into SettlementFields

commit 14b5ace
Author: Garrett Luskey <garrett.luskey@gmail.com>
Date:   Sun Sep 22 17:24:18 2024 -0500

    fix for tests

commit a59798f
Merge: 9be3c4f 3a6a10a
Author: EgardA <veryhasted@gmail.com>
Date:   Sun Sep 22 23:10:40 2024 +0200

    Merge branch 'development' into SettlementFields

commit 9be3c4f
Author: EgardA <veryhasted@gmail.com>
Date:   Sun Sep 22 23:09:06 2024 +0200

    upd

commit 639d162
Author: EgardA <veryhasted@gmail.com>
Date:   Sun Sep 22 10:49:18 2024 +0200

    Update SettlementFieldTests.cs

commit 02650ed
Merge: 9d86679 35f827c
Author: EgardA <veryhasted@gmail.com>
Date:   Sun Sep 22 10:36:58 2024 +0200

    Merge branch 'development' into SettlementFields

commit 9d86679
Author: EgardA <veryhasted@gmail.com>
Date:   Sun Sep 22 02:28:05 2024 +0200

    Update SettlementFieldTests.cs

commit 3d43213
Author: EgardA <veryhasted@gmail.com>
Date:   Sun Sep 22 00:52:47 2024 +0200

    Cleaned a lil bit

commit 78168bd
Author: EgardA <veryhasted@gmail.com>
Date:   Wed Sep 18 21:31:18 2024 +0200

    WIP
@EgardA
PartyBaseSync
e077e7b
@EgardA
Merge branch 'development' into PartyBaseSync
d32e64e
@EgardA
some updated tests
388c4c4
@EgardA EgardA marked this pull request as draft November 15, 2024 09:47
This was linked to issues Nov 15, 2024
Sync: PartyBase Fields #901
Open
Sync: PartyBase Properties #902
Open
@EgardA EgardA marked this pull request as ready for review November 15, 2024 18:07
@EgardA EgardA self-assigned this Nov 15, 2024
georgyrudnev
georgyrudnev requested changes Nov 16, 2024
View reviewed changes
Copy link
Contributor

@georgyrudnev georgyrudnev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I am on my laptop I was not able to run the game to test in-game behaviour.

source/GameInterface/Services/PartyBases/PartyBaseSync.cs Outdated Show resolved Hide resolved
source/E2E.Tests/Services/PartyBases/PartyBaseSyncTests.cs Show resolved Hide resolved
source/E2E.Tests/Services/PartyBases/PartyBaseSyncTests.cs Show resolved Hide resolved
source/GameInterface/Services/TroopRosters/Patches/TroopRosterLifetimePatch.cs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgyrudnev georgyrudnev georgyrudnev requested changes

@garrettluskey garrettluskey Awaiting requested review from garrettluskey

Requested changes must be addressed to merge this pull request.

Assignees

@EgardA EgardA

Labels
None yet
Projects
Sync Backlog
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync: PartyBase Properties Sync: PartyBase Fields
2 participants
@EgardA @georgyrudnev