Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Improve order flow) Patch repeated case sample name rule #3941

Merged
merged 4 commits into from
Nov 15, 2024

Conversation

islean
Copy link
Contributor

@islean islean commented Nov 14, 2024

Description

The rule for sample name repetition for OrderWithCases is quite complex and the current implementation had some issues, mostly with regards to existing cases and samples. The changes in this PR intends to

  1. Always allow repeated sample names for existing samples.
  2. Not allow for repeated sample names within the new samples across the whole order.

Added

Changed

Fixed

  • Always allow repeated sample names for existing samples.
  • Not allow for repeated sample names within the new samples across the whole order.

How to prepare for test

  • Ssh to relevant server (depending on type of change)
  • Use stage: us
  • Paxa the environment: paxa
  • Install on stage (example for Hasta):
    bash /home/proj/production/servers/resources/hasta.scilifelab.se/update-tool-stage.sh -e S_cg -t cg -b [THIS-BRANCH-NAME] -a

How to test

  • Do ...

Expected test outcome

  • Check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • Tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

Implementation Plan

  • Document in ...
  • Deploy this branch on ...
  • Inform to ...

@islean islean requested a review from a team as a code owner November 14, 2024 15:44
@islean islean changed the base branch from master to improve-order-flow-main November 14, 2024 15:44
Copy link
Contributor

@diitaz93 diitaz93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@islean islean merged commit 27f9193 into improve-order-flow-main Nov 15, 2024
8 checks passed
@islean islean deleted the patch-repeated-case-sample-name-rule branch November 15, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants