Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: use set -xeuo pipefail globally #18369

Merged
merged 1 commit into from
Sep 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/actionlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ env:
HOMEBREW_NO_AUTO_UPDATE: 1
HOMEBREW_NO_ENV_HINTS: 1

defaults:
run:
shell: bash -xeuo pipefail {0}

concurrency:
group: "actionlint-${{ github.ref }}"
cancel-in-progress: ${{ github.event_name == 'pull_request' }}
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/autogenerated-files.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ env:
HOMEBREW_DEVELOPER: 1
HOMEBREW_NO_AUTO_UPDATE: 1

defaults:
run:
shell: bash -xeuo pipefail {0}

jobs:
autogenerated:
runs-on: ubuntu-22.04
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ on:
branches:
- master

defaults:
run:
shell: bash -xeuo pipefail {0}

jobs:
analyze:
name: Analyze
Expand Down
8 changes: 6 additions & 2 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ on:
permissions:
contents: read

defaults:
run:
shell: bash -xeuo pipefail {0}

jobs:
ubuntu:
if: github.repository_owner == 'Homebrew'
Expand Down Expand Up @@ -41,7 +45,7 @@ jobs:
date="$(date --rfc-3339=seconds --utc)"
brew_version="$(git describe --tags --dirty --abbrev=7)"

DELIMITER="END_LABELS_$(LC_ALL=C tr -dc '[:alnum:]' </dev/urandom | head -c20)"
DELIMITER="END_LABELS_$(uuidgen)"
cat <<EOS | tee -a "${GITHUB_OUTPUT}"
labels<<${DELIMITER}
org.opencontainers.image.created=${date}
Expand Down Expand Up @@ -82,7 +86,7 @@ jobs:

{
if [[ "${#tags[@]}" -ne 0 ]]; then
DELIMITER="END_TAGS_$(LC_ALL=C tr -dc '[:alnum:]' </dev/urandom | head -c20)"
DELIMITER="END_TAGS_$(uuidgen)"
echo "tags<<${DELIMITER}"
printf "%s\n" "${tags[@]}"
echo "${DELIMITER}"
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ env:
HOMEBREW_BOOTSNAP: 1
HOMEBREW_NO_INSTALL_CLEANUP: 1

defaults:
run:
shell: bash -xeuo pipefail {0}

jobs:
docs:
runs-on: ubuntu-22.04
Expand All @@ -38,8 +42,6 @@ jobs:
- name: Cleanup Homebrew/brew docs
if: github.repository == 'Homebrew/brew'
run: |
set -xeuo pipefail

# Avoid failing on broken symlinks.
rm Library/Homebrew/os/mac/pkgconfig/fuse/fuse.pc
rm Library/Homebrew/os/mac/pkgconfig/fuse/osxfuse.pc
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/doctor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,18 @@ on:
- Library/Homebrew/extend/os/diagnostic.rb
- Library/Homebrew/extend/os/mac/diagnostic.rb
- Library/Homebrew/os/mac/xcode.rb

permissions:
contents: read

env:
HOMEBREW_DEVELOPER: 1
HOMEBREW_NO_AUTO_UPDATE: 1

defaults:
run:
shell: bash -xeuo pipefail {0}

jobs:
determine-runners:
runs-on: ubuntu-22.04
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/pkg-installer.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ env:
PKG_APPLE_DEVELOPER_TEAM_ID: ${{ secrets.PKG_APPLE_DEVELOPER_TEAM_ID }}
HOMEBREW_NO_ANALYTICS_THIS_RUN: 1
HOMEBREW_NO_ANALYTICS_MESSAGE_OUTPUT: 1

defaults:
run:
shell: bash -xeuo pipefail {0}

jobs:
build:
if: github.repository_owner == 'Homebrew' && github.actor != 'dependabot[bot]'
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/rubydoc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@ env:
HOMEBREW_BOOTSNAP: 1
HOMEBREW_NO_INSTALL_CLEANUP: 1

defaults:
run:
shell: bash -xeuo pipefail {0}

jobs:
rubydoc:
if: github.repository == 'Homebrew/brew'
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/schemas.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ on:
permissions:
contents: read

defaults:
run:
shell: bash -xeuo pipefail {0}

jobs:
spdx:
if: github.repository == 'Homebrew/brew'
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/sorbet.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ on:
permissions:
contents: read

defaults:
run:
shell: bash -xeuo pipefail {0}

jobs:
tapioca:
if: github.repository == 'Homebrew/brew'
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/spdx.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ on:
permissions:
contents: read

defaults:
run:
shell: bash -xeuo pipefail {0}

jobs:
spdx:
if: github.repository == 'Homebrew/brew'
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/sponsors-maintainers-man-completions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ on:
permissions:
contents: read

defaults:
run:
shell: bash -xeuo pipefail {0}

jobs:
updates:
runs-on: ubuntu-22.04
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/stale-issues.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@ permissions:
issues: write
pull-requests: write

defaults:
run:
shell: bash -xeuo pipefail {0}

concurrency:
group: stale-issues
cancel-in-progress: ${{ github.event_name != 'issue_comment' }}
Expand Down
6 changes: 5 additions & 1 deletion .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ env:
HOMEBREW_NO_INSTALL_CLEANUP: 1
HOMEBREW_VERIFY_ATTESTATIONS: 1

defaults:
run:
shell: bash -xeuo pipefail {0}

concurrency:
group: "${{ github.ref }}"
cancel-in-progress: ${{ github.event_name == 'pull_request' }}
Expand Down Expand Up @@ -328,7 +332,7 @@ jobs:

# Retry multiple times when using BuildPulse to detect and submit
# flakiness (because rspec-retry is disabled).
if [[ -n "${HOMEBREW_BUILDPULSE_ACCESS_KEY_ID}" ]]
if [[ -n "${HOMEBREW_BUILDPULSE_ACCESS_KEY_ID-}" ]]
then
brew tests ${{ matrix.test-flags }} ||
brew tests ${{ matrix.test-flags }}
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/vendor-gems.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ permissions:
contents: read
pull-requests: read

defaults:
run:
shell: bash -xeuo pipefail {0}

jobs:
vendor-gems:
if: github.repository_owner == 'Homebrew'
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/vendor-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ on:
permissions:
contents: read

defaults:
run:
shell: bash -xeuo pipefail {0}

jobs:
check-vendor-version:
runs-on: ubuntu-22.04
Expand Down
Loading