Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: use set -xeuo pipefail globally #18369

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This makes it easier to avoid subtle shell script bugs.

@carlocab carlocab force-pushed the strict-workflows branch 2 times, most recently from f580ef4 to 634c8a3 Compare September 20, 2024 19:26
.github/workflows/docker.yml Outdated Show resolved Hide resolved
@Bo98
Copy link
Member

Bo98 commented Sep 22, 2024

Looks like there's another delimiter generator later on in the step that you're not hitting in CI but will do in a release workflow. That'll need changing too.

This makes it easier to avoid subtle shell script bugs.
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it (although it seems familiar from somewhere, can't think of where 😉)!

@MikeMcQuaid
Copy link
Member

@carlocab good to self-merge whenever you're 👍🏻 as CI is 🟢

@carlocab
Copy link
Member Author

Yes, will do start of tomorrow so I can be sure to be around if something goes 💥

@carlocab carlocab merged commit b678320 into master Sep 24, 2024
47 checks passed
@carlocab carlocab deleted the strict-workflows branch September 24, 2024 11:21
carlocab added a commit to Homebrew/homebrew-core that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants