🔥 feat: Remove empty lines from tags

Matt-MX · Oct 7, 2024 · 7226a47 · 7226a47
1 parent 27099ef
commit 7226a47
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/main/java/com/mattmx/nametags/config/TextDisplayMetaConfiguration.java b/src/main/java/com/mattmx/nametags/config/TextDisplayMetaConfiguration.java
@@ -16,13 +16,19 @@
 
 import java.util.Locale;
 import java.util.Objects;
+import java.util.stream.Stream;
 
 public class TextDisplayMetaConfiguration {
 
     public static boolean applyTextMeta(@NotNull ConfigurationSection section, @NotNull TextDisplayMeta to, @NotNull Player self, @NotNull Player sender) {
-        Component text = section.getStringList("text")
+        Stream<Component> stream = section.getStringList("text")
             .stream()
             .map((line) -> convertToComponent(self, sender, line))
+            .filter((line) -> line != Component.empty() && !line.children().stream().allMatch((c) -> c == Component.empty()));
+
+        // TODO(matt): Test + Use config for filtering empty lines
+
+        Component text = stream
             .reduce((a, b) -> a.append(Component.newline()).append(b))
             .orElse(null);
 

diff --git a/src/main/java/com/mattmx/nametags/entity/trait/SneakTrait.java b/src/main/java/com/mattmx/nametags/entity/trait/SneakTrait.java
@@ -24,6 +24,7 @@ public void updateSneak(boolean sneaking) {
                 previousBackgroundOpacity = color.getAlpha();
                 previousTextOpacity = meta.getTextOpacity();
 
+                // Not sure if this is vanilla behavior? Does only text opacity change??
                 meta.setBackgroundColor(withCustomSneakOpacity(color).asARGB());
                 meta.setTextOpacity((byte) getCustomOpacity());
             } else {