New PR template #1248
New PR template #1248
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1248 +/- ##
=======================================
Coverage 12% 12%
=======================================
Files 266 266
Lines 7201 7201
=======================================
Hits 806 806
Misses 6395 6395 |
thePeras
force-pushed
the
refactor/pr-template
branch
from
d2cacc0
to
d91f57f
Compare
| # Review Checklist | ||
|
|
||
| - [ ] Writes a summary in `whatsnew/whatsnew-pt-PT` of the new changes | ||
| - [ ] Terms and conditions reflect the changes |
There was a problem hiding this comment.
Terms and conditions should be updated on every PR, if necessary. The reason is the app will be used by beta testers, which are also subject to the terms and conditions of uni.
There was a problem hiding this comment.
I think it can be a little annoying and pushing the responsibility to the person who made the release and its reviews, will allow taking a preoccupation from each PR
There was a problem hiding this comment.
I agree that it is a bit annoying but, with each PR, we are essentially creating a release (for our beta testers). As such, the terms and conditions need to be kept up-to-date for them. If we remove public access from the beta track, we can push this to the release checklist.
|
UI/UX Test with diferent text zoom levels |
|
Add something responsive |
Closes #997
Let's open the debate!!