-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New PR template #1248
Open
thePeras
wants to merge
6
commits into
develop
Choose a base branch
from
refactor/pr-template
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
New PR template #1248
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d91f57f
New PR template
thePeras 9e76004
release template
thePeras d2a488c
pr template .env
thePeras fa89e55
Update pull_request_template.md
thePeras 1551850
Merge branch 'develop' into refactor/pr-template
thePeras a334548
Removed changelog elefant and added performance checklist
thePeras File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
|
|
||
|
|
||
| # Review Checklist | ||
|
|
||
| - [ ] Writes a summary in `whatsnew/whatsnew-pt-PT` of the new changes | ||
| - [ ] Terms and conditions reflect the changes | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,18 @@ | ||
| [ATTENTION. This is the *Pull Request Template*. Replace the two following lines with the indicated information and delete this one. Do not delete anything else] | ||
|
|
||
| Closes #[issue number] | ||
| [Description of the changes proposed in the pull request. Include steps to replicate the behavior and screenshots if UI is updated] | ||
| <!-- | ||
| Description of the changes proposed in the pull request. | ||
| Include steps to replicate the behavior and screenshots if UI is updated. | ||
| If this is release PR select it's template by adding ?template=release_pr_template.md to the url. | ||
| --> | ||
|
|
||
| # Review checklist | ||
| - [ ] Terms and conditions reflect the current change | ||
| - [ ] Contains enough appropriate tests | ||
| - [ ] If aimed at production, writes a new summary in `whatsnew/whatsnew-pt-PT` | ||
| - [ ] Properly adds an entry in `changelog.md` with the change | ||
| - [ ] If PR includes UI updates/additions, its description has screenshots | ||
| - [ ] Behavior is as expected | ||
| - [ ] Clean, well-structured code | ||
|
|
||
| ## View Changes | ||
|
|
||
| - [ ] Tested both in light and dark mode | ||
| - [ ] Description has screenshots of the UI changes | ||
| - [ ] Text is both in portuguese and english. | ||
|
|
||
| ## Documentation | ||
|
|
||
| - [ ] Properly adds an entry in `changelog.md` with the change |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terms and conditions should be updated on every PR, if necessary. The reason is the app will be used by beta testers, which are also subject to the terms and conditions of uni.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can be a little annoying and pushing the responsibility to the person who made the release and its reviews, will allow taking a preoccupation from each PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that it is a bit annoying but, with each PR, we are essentially creating a release (for our beta testers). As such, the terms and conditions need to be kept up-to-date for them. If we remove public access from the beta track, we can push this to the release checklist.