Release 1.2.3 stable.

Network-BEncode-inside · Mar 3, 2024 · 235c0b5 · 235c0b5
2 parents cce6c5f + 768a95b
commit 235c0b5
Show file tree

Hide file tree

Showing 109 changed files with 1,773 additions and 893 deletions.
diff --git a/ChangeLog b/ChangeLog
@@ -1,3 +1,59 @@
+# v 1.2.3  2024-03-03  [stable]
+
+This is a maintenance release with minor bug fixes.
+
+Improvements:
+- Allow final address to be used as a search and sorting column in GUI.
+- Do not hide the "random stats" shell command in the help.
+- Shell "node add" now supports g2:IP:port for G2 nodes.
+
+Bug Fixes:
+- Avoid assertion failure in xmalloc() when the page size is not 4K
+- Fix build on NetBSD with SSP.
+- Avoid conflicting symbol with NetBSD's powerpc/frame.h
+- Force supervisor to quit if child gets a SIGKILL.
+- Forgot to set te->ptid in discovered threads.
+
+Under the Hood:
+- Add aq_on_available() to hide waiter object.
+- Add debugging #define XMALLOC_DISABLED to remap xmalloc() to malloc().
+- Add randomness every minute instead of 30 seconds.
+- Dump held locks when suspending thread with locks.
+- Fix thread_lock_dump() logic.
+- Recent version of glib define G_NORETURN already.
+- Use library popcount() if it exists.
+- Use an integer for atomic_lock_t (or it fails on Darwin ppc32).
+- atio_get_lock(): no need to hash file descriptor.
+- crash_hook_add(): watch out for early inits.
+- crash_init(): ignore subsequent calls, loudly.
+- crash_mode(): disable locking on concurrent crash.
+- dump_hex_vec(): do not re-emit header if reached end.
+- entropy_collect_gateway(): cache initial gateway information.
+- entropy_harvest_many(): accelerate processing.
+- evq_close(): forgot to free local callout queue.
+- getgateway(): avoid endless warnings.
+- hashlist: avoid race condition for moveto operations.
+- random_double_generate(): ensure value is in [0, 1[.
+- ripening_set_expire(): remove faulty assertion.
+- rwlock_deadlocked(): trace locking thread owner.
+- rwlock_lock_granted(): verify waiter presence.
+- rwlock_readers_downto(): issue a memory barrier.
+- shared_file_free(): give more details on assert failure.
+- semaphore_emulate(): was not handling timeout properly.
+- sig_get_pc_index(): also trap SIGBUS for OS/X.
+- socket_tls_upgrade(): synchronous upgrade logged but no longer fatal.
+- str_private(): must use NOT_LEAKING_Z() for walloc().
+- str_slice(): change semantics of `to'.
+- thread_element_reset(): also clear lock stack overflow.
+- thread_lock_dump(): can now omit details if necessary.
+- thread_lock_released(): give more context on problems.
+- thread_sig_handle(): add default handling of TSIG_TERM.
+- vmm_mmap_anonymous(): optimize re-locking.
+- walloc_get_zone(): do not keep lock whilst allocating zone.
+- xmalloc_chunk_allocate(): validate chunk head is sound.
+- zalloc: do not keep lock whilst extending the zone.
+- zget(): limit scope of global spinlock to a minimum.
+
 # v 1.2.2  2022-02-25  [stable]
 
 This is a maintenance release with major bug fixes.

diff --git a/Configure b/Configure
@@ -18,7 +18,7 @@
 
 # $Id$
 #
-# Generated on Sun Jul 12 10:41:08 CEST 2020 [metaconfig 3.5-255]
+# Generated on Wed Dec 28 18:44:06 CET 2022 [metaconfig 3.5-255]
 
 cat >c1$$ <<EOF
 ARGGGHHHH!!!!!
@@ -400,6 +400,7 @@ d_openat=''
 d_pause=''
 d_pipe2=''
 d_poll=''
+d_popcount=''
 d_popen=''
 d_portable=''
 d_posix_fadvise=''
@@ -7429,6 +7430,47 @@ cyn=poll
 set d_poll
 eval $trylink
 
+: see which of string.h or strings.h is needed
+echo " "
+strings=`./findhdr string.h`
+if $test "$strings" && $test -r "$strings"; then
+	echo "Using <string.h> instead of <strings.h>." >&4
+	val="$define"
+else
+	val="$undef"
+	strings=`./findhdr strings.h`
+	if $test "$strings" && $test -r "$strings"; then
+		echo "Using <strings.h> instead of <string.h>." >&4
+	else
+		./warn "No string header found -- You'll surely have problems." 4>&4
+	fi
+fi
+set i_string
+eval $setvar
+case "$i_string" in
+"$undef") strings=`./findhdr strings.h`;;
+*)	  strings=`./findhdr string.h`;;
+esac
+
+: see if popcount exists
+$cat >try.c <<EOC
+#$i_string I_STRING
+#ifdef I_STRING
+#include <string.h>
+#else
+#include <strings.h>
+#endif
+int main(void)
+{
+	static int ret;
+	ret |= popcount(127);
+	return ret ? 0 : 1;
+}
+EOC
+cyn=popcount
+set d_popcount
+eval $trylink
+
 : see if popen exists
 $cat >try.c <<EOC
 #include <stdio.h>
@@ -11032,28 +11074,6 @@ case "$val" in
 esac
 $rm -f varargs*
 
-: see which of string.h or strings.h is needed
-echo " "
-strings=`./findhdr string.h`
-if $test "$strings" && $test -r "$strings"; then
-	echo "Using <string.h> instead of <strings.h>." >&4
-	val="$define"
-else
-	val="$undef"
-	strings=`./findhdr strings.h`
-	if $test "$strings" && $test -r "$strings"; then
-		echo "Using <strings.h> instead of <string.h>." >&4
-	else
-		./warn "No string header found -- You'll surely have problems." 4>&4
-	fi
-fi
-set i_string
-eval $setvar
-case "$i_string" in
-"$undef") strings=`./findhdr strings.h`;;
-*)	  strings=`./findhdr string.h`;;
-esac
-
 : see if this is a sys/ipc system
 set sys/ipc.h i_sysipc
 eval $inhdr
@@ -11656,6 +11676,7 @@ d_pause='$d_pause'
 d_phostname='$d_phostname'
 d_pipe2='$d_pipe2'
 d_poll='$d_poll'
+d_popcount='$d_popcount'
 d_popen='$d_popen'
 d_portable='$d_portable'
 d_posix_fadvise='$d_posix_fadvise'

diff --git a/README b/README
@@ -29,7 +29,7 @@ list on www.sourceforge.net, and more precisely here:
 
 Also visit the main website for news, updates, FAQ, and more at:
 
-    http://gtk-gnutella.sourceforge.net/
+    https://gtk-gnutella.sourceforge.io/
 
 
 Introduction
@@ -60,24 +60,24 @@ AMD64, PowerPC, SPARC, MIPS.
 It is released under the GNU General Public License (GPL).  
 
 For further information on Gnutella, try:
-    http://rfc-gnutella.sourceforge.net/
+    https://rfc-gnutella.sourceforge.net/
 
 The gtk-gnutella Home Page is:
-    http://gtk-gnutella.sourceforge.net/
+    https://gtk-gnutella.sourceforge.io/
 
 The Project Page is:
-    http://sourceforge.net/projects/gtk-gnutella/
+    https://sourceforge.net/projects/gtk-gnutella/
 
 Open Discussion Forums, try:
-    http://www.gnutellaforums.com/
+    https://www.gnutellaforums.com/
 
 There is an IRC channel for gtk-gnutella on https://libera.chat:
     irc.libera.chat #gtk-gnutella
 
 Mailing lists
 
-    http://lists.sourceforge.net/mailman/listinfo/gtk-gnutella-devel
-    http://lists.sourceforge.net/mailman/listinfo/gtk-gnutella-users
+    https://sourceforge.net/projects/gtk-gnutella/lists/gtk-gnutella-devel
+    https://sourceforge.net/projects/gtk-gnutella/lists/gtk-gnutella-users
 
 
 Installation

diff --git a/config_h.SH b/config_h.SH
@@ -602,6 +602,12 @@ sed <<!GROK!THIS! >$CONFIG_H -e 's!^#undef\(.*/\)\*!/\*#define\1 \*!' -e 's!^#un
  */
 #$d_poll HAS_POLL		/**/
 
+/* HAS_POPCOUNT:
+ *	This symbol, if defined, indicates that the popcount routine is
+ *	available to count the amount of '1' bits in a word.
+ */
+#$d_popcount HAS_POPCOUNT	/**/
+
 /* HAS_POPEN:
  *	This symbol, if defined, indicates that the popen routine is
  *	available to open a pipe from a process.

diff --git a/debian/changelog b/debian/changelog
@@ -1,3 +1,9 @@
+gtk-gnutella (1.2.3-1) unstable; urgency=high
+
+  * New upstream release with minor bug fixes.
+
+ -- Raphael Manfredi <Raphael_Manfredi@pobox.com>  Sun,  3 Mar 2024 12:01:09 +0000
+
 gtk-gnutella (1.2.2-1) unstable; urgency=high
 
   * New upstream release with major bug fixes.

diff --git a/debian/control b/debian/control
@@ -22,4 +22,4 @@ Description: shares files in a peer to peer network
  statistics, queuing, and of course total control over many configuration
  parameters.
  .
- Homepage: http://gtk-gnutella.sourceforge.net/
+ Homepage: https://gtk-gnutella.sourceforge.io/
diff --git a/doc/gnutella/IPv6 b/doc/gnutella/IPv6
@@ -12,7 +12,7 @@ Hi,
 consider this a follow-up to the below mentioned thread:
 http://groups.yahoo.com/group/the_gdf/messages/8898
 
-gtk-gnutella ( http://gtk-gnutella.sourceforge.net/ ) has been
+gtk-gnutella ( https://gtk-gnutella.sourceforge.io/ ) has been
 extended to support IPv6 in current CVS. While it's working, it should
 still be considered experimental. Therefore, the relevant new GGEP
 extensions are only defined in the GTKG namespace:

diff --git a/doc/manual/gtk-gnutella.dsl b/doc/manual/gtk-gnutella.dsl
@@ -73,10 +73,10 @@
     (make formatting-instruction data: ">gtk-gnutella development ")
     (literal "hosted by")
     (make formatting-instruction data: "&#60a class=")
-    (literal "\"image\" href=\"http://sourceforge.net\"")
+    (literal "\"image\" href=\"https://sourceforge.net\"")
     (make formatting-instruction data: ">&#60img ")
     (literal "style=\"vertical-align:middle;\" ")
-    (literal "src=\"http://sourceforge.net/sflogo.php")
+    (literal "src=\"https://sourceforge.net/sflogo.php")
     (literal "?group_id=4467")
     (make formatting-instruction data: "&#38amp;type=1\" ")
     (literal "alt=\"SourceForge.net Logo\" width=\"88\" height=\"31\"/")

diff --git a/doc/manual/manual.xml b/doc/manual/manual.xml
@@ -67,7 +67,7 @@ Document style
   text to update and expand the manual, but please feel free to
   contribute new sections and updates if you like.  Information on
   contributing can be found at <ulink
-  url="http://gtk-gnutella.sourceforge.net/"/></para>
+  url="https://gtk-gnutella.sourceforge.io/"/></para>
 
 </preface>
 
@@ -125,11 +125,11 @@ url="http://rpmfind.net/linux/rpm2html/search.php?query=gtk-gnutella">
 RPM find </ulink> and <ulink
 url="http://linuxappfinder.com/package/gtk-gnutella"> Linux App finder
 </ulink> have packages for some popular Linux distributions.  Also,
-the <ulink url="http://gtk-gnutella.sourceforge.net/"> gtk-gnutella
+the <ulink url="https://gtk-gnutella.sourceforge.io/"> gtk-gnutella
 </ulink> web site may contains some packages. </para>
 
 <para>A better way to get gtk-gnutella is to install it yourself. The
-<ulink url="http://gtk-gnutella.sourceforge.net/"> gtk-gnutella
+<ulink url="https://gtk-gnutella.sourceforge.io/"> gtk-gnutella
 </ulink> web site contains the source archive which allows you to
 compile gtk-gnutella yourself. You can also use the web site to check
 if your currently installed version is still the most recent version;

diff --git a/osx/Info-gtk-gnutella.plist.tpl b/osx/Info-gtk-gnutella.plist.tpl
@@ -7,7 +7,7 @@
     <key>CFBundleExecutable</key>
     <string>Gtk-Gnutella</string>
     <key>CFBundleGetInfoString</key>
-    <string>CFBundleShortVersionStringPlaceHolder, (C) 2000-2011 gtk-gnutella http://gtk-gnutella.sourceforge.net</string>
+    <string>CFBundleShortVersionStringPlaceHolder, (C) 2000-2011 gtk-gnutella https://gtk-gnutella.sourceforge.io</string>
     <key>CFBundleIconFile</key>
     <string>gtk-gnutella.icns</string>
     <key>CFBundleIdentifier</key>

diff --git a/po/de.po b/po/de.po
@@ -8464,8 +8464,8 @@ msgstr "Version"
 msgid "Vidar Madsen"
 msgstr ""
 
-msgid "Visit http://gtk-gnutella.sourceforge.net/."
-msgstr "Besuche http://gtk-gnutella.sourceforge.net/."
+msgid "Visit https://gtk-gnutella.sourceforge.io/."
+msgstr "Besuche https://gtk-gnutella.sourceforge.io/."
 
 msgid "Volume:"
 msgstr "Übertragungsvolumen:"
@@ -9681,8 +9681,7 @@ msgstr "Lese Ultra-Cache..."
 msgid ""
 "<html><head><title>Ancient version detected!</title></"
 "head><body><h1>Warning</h1><p>This version of gtk-gnutella is pretty old. "
-"Please visit <a href=\"http://gtk-gnutella.sourceforge.net/\">http://gtk-"
-"gnutella.sourceforge.net/</a> and update your copy of gtk-gnutella.</p></"
+"Please visit <a href=\"https://gtk-gnutella.sourceforge.io/\">https://gtk-gnutella.sourceforge.io/</a> and update your copy of gtk-gnutella.</p></"
 "body></html>"
 msgstr ""
 

diff --git a/po/el.po b/po/el.po
@@ -8465,8 +8465,8 @@ msgstr "Έκδοση"
 msgid "Vidar Madsen"
 msgstr ""
 
-msgid "Visit http://gtk-gnutella.sourceforge.net/."
-msgstr "Επισκεφτείτε το http://gtk-gnutella.sourceforge.net/."
+msgid "Visit https://gtk-gnutella.sourceforge.io/."
+msgstr "Επισκεφτείτε το https://gtk-gnutella.sourceforge.io/."
 
 msgid "Volume:"
 msgstr "Μέγεθος:"
@@ -9675,8 +9675,7 @@ msgstr "Ανάγνωση λανθάνουσας μνήμης υπερ-κόμβω
 msgid ""
 "<html><head><title>Ancient version detected!</title></"
 "head><body><h1>Warning</h1><p>This version of gtk-gnutella is pretty old. "
-"Please visit <a href=\"http://gtk-gnutella.sourceforge.net/\">http://gtk-"
-"gnutella.sourceforge.net/</a> and update your copy of gtk-gnutella.</p></"
+"Please visit <a href=\"https://gtk-gnutella.sourceforge.io/\">hhttps://gtk-gnutella.sourceforge.io/</a> and update your copy of gtk-gnutella.</p></"
 "body></html>"
 msgstr ""
 

diff --git a/po/es.po b/po/es.po
@@ -8729,8 +8729,8 @@ msgstr "Versión"
 msgid "Vidar Madsen"
 msgstr "Vidar Madsen"
 
-msgid "Visit http://gtk-gnutella.sourceforge.net/."
-msgstr "Visite http://gtk-gnutella.sourceforge.net/."
+msgid "Visit https://gtk-gnutella.sourceforge.io/."
+msgstr "Visite https://gtk-gnutella.sourceforge.io/."
 
 msgid "Volume:"
 msgstr "Volumen:"
@@ -9561,12 +9561,11 @@ msgstr[1] "%d segundos"
 
 msgid ""
 "<html><head><title>Frequently Asked Questions</title></head><body><p>The FAQ "
-"document could not be loaded. Please read the <a href=\"http://gtk-gnutella."
-"sourceforge.net/?page=faq\">FAQ online</a> instead.</p></body></html>"
+"document could not be loaded. Please read the <a href=\"https://gtk-gnutella.sourceforge.io/?page=faq\">FAQ online</a> instead.</p></body></html>"
 msgstr ""
 "<html><head><title>Preguntas Frecuentes</title></head><body><p>El documento "
 "que contiene las Preguntas Frecuentes no ha podido ser cargado. Por favor, "
-"lea las <a href=\"http://gtk-gnutella.sourceforge.net/?page=faq\">Preguntas "
+"lea las <a href=\"https://gtk-gnutella.sourceforge.io/?page=faq\">Preguntas "
 "Frecuentes en línea</a>.</p></body></html>"
 
 msgid ""
@@ -9962,14 +9961,13 @@ msgstr "Leyendo cache de ultranodos..."
 msgid ""
 "<html><head><title>Ancient version detected!</title></"
 "head><body><h1>Warning</h1><p>This version of gtk-gnutella is pretty old. "
-"Please visit <a href=\"http://gtk-gnutella.sourceforge.net/\">http://gtk-"
-"gnutella.sourceforge.net/</a> and update your copy of gtk-gnutella.</p></"
+"Please visit <a href=\"https://gtk-gnutella.sourceforge.io/\">https://gtk-gnutella.sourceforge.io/</a> and update your copy of gtk-gnutella.</p></"
 "body></html>"
 msgstr ""
 "<html><head><title>¡Detectada versión anticuada!</title></"
 "head><body><h1>Advertencia</h1><p>esta versión de gtk-gnutella es bastante "
-"vieja. Por favor, visita <a href=\"http://gtk-gnutella.sourceforge.net/"
-"\">http://gtk-gnutella.sourceforge.net/</a> y actualiza tu copia de gtk-"
+"vieja. Por favor, visita <a href=\"hhttps://gtk-gnutella.sourceforge.io/"
+"\">https://gtk-gnutella.sourceforge.io/</a> y actualiza tu copia de gtk-"
 "gnutella.</p></body></html>"
 
 msgid "*** RUNNING AN OLD VERSION! ***"