Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test suite results and improved table formatting #80

Merged
merged 4 commits into from
Nov 14, 2024
Merged

Conversation

stellaprins
Copy link
Collaborator

Compatibility processing

  • reformat compatibility message (remove colour coding of text)
  • In addition to recognizing .sbml and .sedml files as SBML and SED-ML format, .xml files with 'sedml' + 'sbml' or 'sbml' but not 'sedml' in their filename are recognized as SBML and SED-ML files. Other file types are not recognized but this can be extended in the future.
  • Instead of ❌ FAIL, unrecognized filetypes will marked as ❓UNSURE (this hasn't happened so far). At the moment all engines that do not support SBML/SED-ML are still marked as⚠ XFAIL.

Test suite

  • Updated the results table of case 00001
  • Added a table of case 01186 (steady state Flux Balance Analysis)

Add back foldout menu in Engines column (went lost with the previous PR when the engine names were reformated)

Compatibility processing

-    reformat compatibility message (remove colour coding of text)
-    In addition to recognizing .sbml and .sedml files as SBML and SED-ML format, .xml files with 'sedml' + 'sbml' or 'sbml' but not 'sedml' in their filename are recognized as SBML and SED-ML files. Other file types are not recognized but this can be extended in the future.
-    Instead of ❌ FAIL, unrecognized filetypes will marked as ❓UNSURE (this hasn't happened so far). At the moment all engines that do not support SBML/SED-ML are still marked as⚠ XFAIL.

Test suite

-    Updated the results table of case 00001
-    Added a table of case 01186 (steady state Flux Balance Analysis)

Add back foldout menu in Engines column (went lost with the previous PR when the engine names were reformated)
@stellaprins stellaprins requested review from robertvi, sanjayankur31 and pgleeson and removed request for robertvi November 11, 2024 11:29
@stellaprins stellaprins marked this pull request as draft November 11, 2024 11:53
@stellaprins stellaprins marked this pull request as ready for review November 11, 2024 12:01
@stellaprins
Copy link
Collaborator Author

@sanjayankur31 @pgleeson thanks for flagging up the column with unexpected fails in one of the test_00001 results columns. This is now fixed on development so this PR should be ready to be merged (see table).

@pgleeson
Copy link
Member

Great, thanks @stellaprins!

@pgleeson pgleeson merged commit 43f8b88 into master Nov 14, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants