Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check on nedb usage and node >=23 #6538

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PTR-inc
Copy link
Contributor

@PTR-inc PTR-inc commented Nov 16, 2024

'fixes' #6503

@si458
Copy link
Collaborator

si458 commented Nov 16, 2024

I have spoken with @Ylianst he wants to keep nedb!
So we are gunna look for another nedb fork that is newer and works with v23 then move to that instead

@si458
Copy link
Collaborator

si458 commented Nov 16, 2024

If we implemented this PR it would break all existing setups so hense we looking for another module instead

But also we should inform the user they can use --nedbtodb to migrate there existing nedb to any db they setup

@PTR-inc
Copy link
Contributor Author

PTR-inc commented Nov 16, 2024

Maybe already put a deprecation inform/warning in the current version, as a server message?

I quickchecked the original nedb btw and at first glance it doesn't seem like a very big job to fix the deprecated util functions.

@si458
Copy link
Collaborator

si458 commented Nov 16, 2024

@PTR-inc agreed it looks like a simple fix from the forked repo we use, but there is other repositorys that replaces the util completely, which might be more ideal!

Maybe a warning to tell others to move to a different database but will ask @Ylianst

@PTR-inc
Copy link
Contributor Author

PTR-inc commented Nov 16, 2024

If somebody already did it, better ofcourse! Which ones are you looking at?

@PTR-inc
Copy link
Contributor Author

PTR-inc commented Nov 16, 2024

Added the warning. Just for completeness. Do you want to replace the module before the next release?

@si458
Copy link
Collaborator

si458 commented Nov 16, 2024

@PTR-inc I will speak with @Ylianst and ask his opinion as currently this pr would stop it working all together, as u have removed the nedb module and also out the warning, let me come bk to u

@PTR-inc
Copy link
Contributor Author

PTR-inc commented Nov 16, 2024

@si458 Node 23 errors out if the current nedb module is used, so exitting gracefully if trying to use nedb seemed like the nicer option to offer with a clear message. But a replacement module would be better for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants