Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check on nedb usage and node >=23 #6538

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Check on nedb usage and node >=23 #6538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f907d85
Check on nedb usage and node >=23
PTR-inc Nov 16, 2024
2ff9247
add nedb deprecation message
PTR-inc Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion db.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3388,7 +3388,7 @@ module.exports.CreateDB = function (parent, func) {
} catch (ex) { console.log(ex); }
});
} else {
func();
func(1, "NeDB is deprecated from Node 23 onward, please consider moving to another databasetype using the '--NeDBtoDB' option.");
}
}

Expand Down
13 changes: 10 additions & 3 deletions meshcentral.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@
"use strict";

const common = require('./common.js');

const [nodeMajor, nodeMinor, nodePatch] = process.versions.node.split('.').map(Number)

// If app metrics is available
if (process.argv[2] == '--launch') { try { require('appmetrics-dash').monitor({ url: '/', title: 'MeshCentral', port: 88, host: '127.0.0.1' }); } catch (ex) { } }

Expand Down Expand Up @@ -4123,7 +4124,7 @@ var childProcess = null;
var previouslyInstalledModules = {};
function mainStart() {
// Check the NodeJS is version 16 or better.
if (Number(process.version.match(/^v(\d+\.\d+)/)[1]) < 16) { console.log("MeshCentral requires Node v16 or above, current version is " + process.version + "."); return; }
if (nodeMajor < 16) { console.log("MeshCentral requires Node v16 or above, current version is " + process.version + "."); return; }

// If running within the node_modules folder, move working directory to the parent of the node_modules folder.
if (__dirname.endsWith('\\node_modules\\meshcentral') || __dirname.endsWith('/node_modules/meshcentral')) { process.chdir(require('path').join(__dirname, '..', '..')); }
Expand Down Expand Up @@ -4212,7 +4213,13 @@ function mainStart() {

// Build the list of required modules
// NOTE: ALL MODULES MUST HAVE A VERSION NUMBER AND THE VERSION MUST MATCH THAT USED IN Dockerfile
var modules = ['archiver@7.0.1', 'body-parser@1.20.3', 'cbor@5.2.0', 'compression@1.7.4', 'cookie-session@2.1.0', 'express@4.21.1', 'express-handlebars@7.1.3', 'express-ws@5.0.2', 'ipcheck@0.1.0', 'minimist@1.2.8', 'multiparty@4.2.3', '@yetzt/nedb', 'node-forge@1.3.1', 'ua-parser-js@1.0.39', 'ws@8.18.0', 'yauzl@2.10.0'];
var modules = ['archiver@7.0.1', 'body-parser@1.20.3', 'cbor@5.2.0', 'compression@1.7.4', 'cookie-session@2.1.0', 'express@4.21.1', 'express-handlebars@7.1.3', 'express-ws@5.0.2', 'ipcheck@0.1.0', 'minimist@1.2.8', 'multiparty@4.2.3', 'node-forge@1.3.1', 'ua-parser-js@1.0.39', 'ws@8.18.0', 'yauzl@2.10.0'];

//NeDB only supported on v22 and below, check if needed
if (!(config.settings?.sqlite3 || config.settings?.acebase || config.settings?.mysql || config.settings?.mariadb || config.settings?.mongodb || config.settings?.postgres || config.settings?.xmongodb)) {
if (nodeMajor >=23){ console.log("Using MeshCentral with NeDB requires Node v22 or lower, current version is " + process.version + "."); process.exit(0); } else { modules.push('@yetzt/nedb'); }
};

if (require('os').platform() == 'win32') { modules.push('node-windows@0.1.14'); modules.push('loadavg-windows@1.1.1'); if (sspi == true) { modules.push('node-sspi@0.2.10'); } } // Add Windows modules
if (ldap == true) { modules.push('ldapauth-fork@5.0.5'); }
if (ssh == true) { modules.push('ssh2@1.16.0'); }
Expand Down
Loading