-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASSET-5] Add asset images #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jormal <jormal@naver.com>
Signed-off-by: jormal <jormal@naver.com>
Signed-off-by: jormal <jormal@naver.com>
auto-assign
bot
requested review from
gihyeonsung,
oh51dy,
yjkellyjoo and
zibersaioros
January 18, 2024 10:09
zibersaioros
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㄷㄷ
yjkellyjoo
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ㄷㄷ 22
jormal
added a commit
that referenced
this pull request
Jan 19, 2024
* [ASSET-5] Refactor the scripts (#8) * ASSET-5 Upgrade python version to 3.12 Signed-off-by: jormal <jormal@naver.com> * ASSET-5 Substitute typing_extensions to typing Signed-off-by: jormal <jormal@naver.com> * ASSET-5 Remove asynchrony Signed-off-by: jormal <jormal@naver.com> * ASSET-5 Add models and refactor scripts Signed-off-by: jormal <jormal@naver.com> * ASSET-5 Add enum ID preprocess Signed-off-by: jormal <jormal@naver.com> * ASSET-5 Add tag test Signed-off-by: jormal <jormal@naver.com> * ASSET-5 Add address checksum test Signed-off-by: jormal <jormal@naver.com> * ASSET-5 Fix the info to pass the test Signed-off-by: jormal <jormal@naver.com> --------- Signed-off-by: jormal <jormal@naver.com> * [ASSET-5] �Add asset images (#9) * ASSET-5 Add exists assets' images Signed-off-by: jormal <jormal@naver.com> * ASSET-5 Add images and info Signed-off-by: jormal <jormal@naver.com> * ASSET-5 Update enums Signed-off-by: jormal <jormal@naver.com> --------- Signed-off-by: jormal <jormal@naver.com> --------- Signed-off-by: jormal <jormal@naver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
CoinmarketCap top30을 비롯한 여러 asset image를 추가합니다.
Related issue: ASSET-5
Changes
Types of Changes (multiple options can be selected)
{{Please add description here}}
Checklist