Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASSET-5] Add asset images #9

Merged
merged 3 commits into from
Jan 19, 2024
Merged

Conversation

jormal
Copy link
Collaborator

@jormal jormal commented Jan 18, 2024

Pull Request

Description

CoinmarketCap top30을 비롯한 여러 asset image를 추가합니다.

Related issue: ASSET-5

Changes

  • da8b38e: 기존 미리 추가해두었던 asset들에 대해 image를 추가합니다.
  • 5b4d4e4: 추가 이미지를 반영합니다.
  • 08e00fa: 정보가 update됨에 따라 enum을 추가합니다.

Types of Changes (multiple options can be selected)

  • Create asset information
  • Update asset information
  • Delete asset information
  • Other {{Please add description here}}

Checklist

  • Did you pass the tests?
  • Did you run the pre-process?
  • Have you added and run tests to validate the changes?

Signed-off-by: jormal <jormal@naver.com>
Signed-off-by: jormal <jormal@naver.com>
Signed-off-by: jormal <jormal@naver.com>
@jormal jormal added the asset_create Create the asset information label Jan 18, 2024
@jormal jormal self-assigned this Jan 18, 2024
@jormal jormal marked this pull request as ready for review January 18, 2024 10:09
@jormal jormal requested a review from a team as a code owner January 18, 2024 10:09
Copy link

@zibersaioros zibersaioros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㄷㄷ

Copy link

@yjkellyjoo yjkellyjoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㄷㄷ 22

@jormal jormal merged commit bc5fef0 into feature/ASSET-5 Jan 19, 2024
1 check passed
@jormal jormal deleted the feature/ASSET-5.02-AddAssets branch January 19, 2024 00:28
@jormal jormal mentioned this pull request Jan 19, 2024
7 tasks
jormal added a commit that referenced this pull request Jan 19, 2024
* [ASSET-5] Refactor the scripts (#8)

* ASSET-5 Upgrade python version to 3.12

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Substitute typing_extensions to typing

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Remove asynchrony

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Add models and refactor scripts

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Add enum ID preprocess

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Add tag test

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Add address checksum test

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Fix the info to pass the test

Signed-off-by: jormal <jormal@naver.com>

---------

Signed-off-by: jormal <jormal@naver.com>

* [ASSET-5] �Add asset images (#9)

* ASSET-5 Add exists assets' images

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Add images and info

Signed-off-by: jormal <jormal@naver.com>

* ASSET-5 Update enums

Signed-off-by: jormal <jormal@naver.com>

---------

Signed-off-by: jormal <jormal@naver.com>

---------

Signed-off-by: jormal <jormal@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
asset_create Create the asset information
Development

Successfully merging this pull request may close these issues.

3 participants