Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dependencies and react to v18 #1538

Merged
merged 22 commits into from
Sep 20, 2023
Merged

feat: update dependencies and react to v18 #1538

merged 22 commits into from
Sep 20, 2023

Conversation

silviuaavram
Copy link
Collaborator

@silviuaavram silviuaavram commented Sep 6, 2023

What:
Update all dependencies including React 18.

Why:
Be up to date and properly support React 18 by actually using it in the library.
Fixes #1525.
Fixes #1384.

How:

  • update all dependencies.
  • fix and update codebase and tests according to the new versions of the dependencies:
    • remove test:flow_coverage as it fails
    • replace StatelessComponent with FunctionComponent
    • fix all jest fake timers calls.
    • fix compute scroll into view import.
    • tests to support both React.useId and generateId.
    • do not add status div if there will be no need for it.
    • do not use {} as a default prop for environment. Properly check for undefined in its usages.
    • update eslint config and codebase after eslint version update.
    • use renderHook from RTL and remove hooks testing lib.
    • fix code coverage value.
    • improve import tests to cover the hooks and all the builds.

Checklist:

  • Documentation
  • Tests
  • TypeScript Types
  • Flow Types
  • Ready to be merged

@silviuaavram silviuaavram changed the title Feat/react 18 feat: update dependencies and react to v18 Sep 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 16, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (90d6d72) 100.00% compared to head (f3075be) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1538   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1715      1722    +7     
  Branches       511       512    +1     
=========================================
+ Hits          1715      1722    +7     
Files Changed Coverage Δ
src/hooks/useSelect/utils.ts 100.00% <ø> (ø)
src/downshift.js 100.00% <100.00%> (ø)
src/hooks/testUtils.js 100.00% <100.00%> (ø)
src/hooks/useCombobox/index.js 100.00% <100.00%> (ø)
src/hooks/useCombobox/testUtils.js 100.00% <100.00%> (ø)
src/hooks/useMultipleSelection/index.js 100.00% <100.00%> (ø)
src/hooks/useMultipleSelection/testUtils.js 100.00% <100.00%> (ø)
src/hooks/useSelect/index.js 100.00% <100.00%> (ø)
src/hooks/useSelect/testUtils.js 100.00% <100.00%> (ø)
src/hooks/utils.js 100.00% <100.00%> (ø)
... and 2 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@silviuaavram silviuaavram mentioned this pull request Sep 19, 2023
5 tasks
@github-actions
Copy link

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v8: Prop type warning during server-side rendering React 18 support
2 participants