Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop all messages we wouldn't rebroadcast (pubsub related) #583

Closed
Stebalien opened this issue Aug 23, 2024 · 2 comments · Fixed by #649
Closed

Drop all messages we wouldn't rebroadcast (pubsub related) #583

Stebalien opened this issue Aug 23, 2024 · 2 comments · Fixed by #649
Assignees
@masih
Milestone
Milestone 2: F3 H...

Comments

@Stebalien
Copy link
Member

Stebalien commented Aug 23, 2024 •
edited
Loading

This will help us quiet down pubsub between instances and should help us save some bandwidth. This also means we can punt fixing #576 because the only messages that "loop" are messages we want to rebroadcast anyways.
@github-project-automation github-project-automation bot moved this to Todo in F3 Aug 23, 2024
@Stebalien
Copy link
Member Author

Even better, we can drop everything we wouldn't rebroadcast. This likely depends on #561.

@Stebalien Stebalien changed the title Drop all messages except DECIDE once we reach a decision Drop all messages we wouldn't rebroadcast Sep 3, 2024
@Stebalien Stebalien self-assigned this Sep 3, 2024
@Stebalien Stebalien mentioned this issue Sep 3, 2024
Open
3 tasks
@rjan90 rjan90 moved this from Todo to In progress in F3 Sep 10, 2024
@BigLep BigLep changed the title Drop all messages we wouldn't rebroadcast Drop all messages we wouldn't rebroadcast (pubsub related) Sep 13, 2024
@masih masih self-assigned this Sep 19, 2024
@masih masih moved this from Todo to In progress in F3 Sep 19, 2024
masih added a commit that referenced this issue Sep 20, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
4cb81c0 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
@masih masih mentioned this issue Sep 20, 2024
Merged
masih added a commit that referenced this issue Sep 20, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
e6a8851 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
masih added a commit that referenced this issue Sep 20, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
9235404 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
masih added a commit that referenced this issue Sep 20, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
76bc018 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
masih added a commit that referenced this issue Sep 21, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
1b50bb8 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
masih added a commit that referenced this issue Sep 21, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
92b32f2 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
masih added a commit that referenced this issue Sep 21, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
a0e155b 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
@masih
Copy link
Member

masih commented Sep 21, 2024 •
edited
Loading

The implementation of this would be very ugly and error-prone without #561 (See #649). After a few iterations, I think we should get 561 done first. I am therefore going to pick it up and base 649 atop it.

masih added a commit that referenced this issue Sep 23, 2024
@masih
Refactor validation logic into a mutex-free pluggable struct
d6f33e5 
Refactor the validation logic out of `Participant` and into its own
dedicated struct that is mutex-free and listens to the progress made by
the participant to infer the correct validation path.

The change above significantly reduces the need for mutex control over
current instance, which makes it easier to plug in extra conditional
behaviour, e.g. #583.

Fixes #561
@masih masih mentioned this issue Sep 23, 2024
Merged
masih added a commit that referenced this issue Sep 23, 2024
@masih
Refactor validation logic into a mutex-free pluggable struct
c49ae37 
Refactor the validation logic out of `Participant` and into its own
dedicated struct that is mutex-free and listens to the progress made by
the participant to infer the correct validation path.

The change above significantly reduces the need for mutex control over
current instance, which makes it easier to plug in extra conditional
behaviour, e.g. #583.

Fixes #561
masih added a commit that referenced this issue Sep 23, 2024
@masih
Refactor validation logic into a mutex-free pluggable struct
b387cf7 
Refactor the validation logic out of `Participant` and into its own
dedicated struct that is mutex-free and listens to the progress made by
the participant to infer the correct validation path.

The change above significantly reduces the need for mutex control over
current instance, which makes it easier to plug in extra conditional
behaviour, e.g. #583.

Fixes #561
masih added a commit that referenced this issue Sep 23, 2024
@masih
Refactor validation logic into a mutex-free pluggable struct
52e06c4 
Refactor the validation logic out of `Participant` and into its own
dedicated struct that is mutex-free and listens to the progress made by
the participant to infer the correct validation path.

The change above significantly reduces the need for mutex control over
current instance, which makes it easier to plug in extra conditional
behaviour, e.g. #583.

Fixes #561
masih added a commit that referenced this issue Sep 23, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
fb2badd 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
masih added a commit that referenced this issue Sep 23, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
31e65c1 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
masih added a commit that referenced this issue Sep 23, 2024
@masih
Refactor validation logic into a mutex-free pluggable struct
380fc6c 
Refactor the validation logic out of `Participant` and into its own
dedicated struct that is mutex-free and listens to the progress made by
the participant to infer the correct validation path.

The change above significantly reduces the need for mutex control over
current instance, which makes it easier to plug in extra conditional
behaviour, e.g. #583.

Fixes #561
masih added a commit that referenced this issue Sep 23, 2024
@masih
Refactor validation logic into a mutex-free pluggable struct
5c00dc0 
Refactor the validation logic out of `Participant` and into its own
dedicated struct that is mutex-free and listens to the progress made by
the participant to infer the correct validation path.

The change above significantly reduces the need for mutex control over
current instance, which makes it easier to plug in extra conditional
behaviour, e.g. #583.

Fixes #561
masih added a commit that referenced this issue Sep 23, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
628ff0a 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
masih added a commit that referenced this issue Sep 23, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
a9c2397 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
masih added a commit that referenced this issue Sep 23, 2024
@masih
Refactor validation logic into a mutex-free pluggable struct
13cb79b 
Refactor the validation logic out of `Participant` and into its own
dedicated struct that is mutex-free and listens to the progress made by
the participant to infer the correct validation path.

The change above significantly reduces the need for mutex control over
current instance, which makes it easier to plug in extra conditional
behaviour, e.g. #583.

Fixes #561
masih added a commit that referenced this issue Sep 23, 2024
@masih
Refactor validation logic into a mutex-free pluggable struct
9fad427 
Refactor the validation logic out of `Participant` and into its own
dedicated struct that is mutex-free and listens to the progress made by
the participant to infer the correct validation path.

The change above significantly reduces the need for mutex control over
current instance, which makes it easier to plug in extra conditional
behaviour, e.g. #583.

Fixes #561
masih added a commit that referenced this issue Sep 23, 2024
@masih
Refactor validation logic into a mutex-free pluggable struct
214c2b3 
Refactor the validation logic out of `Participant` and into its own
dedicated struct that is mutex-free and listens to the progress made by
the participant to infer the correct validation path.

The change above significantly reduces the need for mutex control over
current instance, which makes it easier to plug in extra conditional
behaviour, e.g. #583.

Fixes #561
masih added a commit that referenced this issue Sep 23, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
70639ba 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
masih added a commit that referenced this issue Sep 23, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
7975dfe 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
github-merge-queue bot pushed a commit that referenced this issue Sep 23, 2024
@masih
Refactor validation logic into a mutex-free pluggable struct (#657)
76ecca1 
Refactor the validation logic out of `Participant` and into its own
dedicated struct that is mutex-free and listens to the progress made by
the participant to infer the correct validation path.

The change above significantly reduces the need for mutex control over
current instance, which makes it easier to plug in extra conditional
behaviour, e.g. #583.

Fixes #561
masih added a commit that referenced this issue Sep 23, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
984caa9 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
masih added a commit that referenced this issue Sep 23, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
7dda4e8 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
masih added a commit that referenced this issue Sep 23, 2024
@masih
Drop messages that are no longer useful for GPBFT progression
0503f70 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
github-merge-queue bot pushed a commit that referenced this issue Sep 23, 2024
@masih
Drop messages that are no longer useful for GPBFT progression (#649)
b7576c8 
As a GPBFT instance progresses some messages become irrelevant, in that
they do not effectively aid the progress of the instance for
participants. Instead, GPBFT offers other built-in mechanisms to aid
progress of lagging participants such as selective
rebroadcast, propagation of DECIDE messages from the previous instance
and finality certificate exchange.

The changes here introduce a dedicated error type returned as part of
message validation to signal that although a message is valid it is no
longer relevant. This error type is then checked by pubsub to avoid
further propagation of those messages.

This reduces the redundant pubsub traffic for the network participants.

Fixes #583
@github-project-automation github-project-automation bot moved this from In progress to Done in F3 Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masih masih

Labels
None yet
Projects
F3
Status: Done
Milestone
Milestone 2: F3 Hardening and Mainnet...
Development

Successfully merging a pull request may close this issue.

Drop messages that are no longer useful for GPBFT progression filecoin-project/go-f3
2 participants
@masih @Stebalien