Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(log): demote log level to DEBUG on skipping forwards based on cert #724

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

hanabi1224
Copy link
Contributor

When bootstrapping a Forest or Lotus node from scratch with the latest snapshot (mostly on CI), F3 downloads certificates from instance 0 and floods stdout with tons of skipping forwards based on cert.

This PR proposes demoting its log level to DEBUG as it does not seem to be as important as other INFO logs under f3.

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.01%. Comparing base (322dc35) to head (9db8a7c).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
- Coverage   75.23%   75.01%   -0.22%     
==========================================
  Files          69       69              
  Lines        6928     6928              
==========================================
- Hits         5212     5197      -15     
- Misses       1306     1317      +11     
- Partials      410      414       +4     
Files with missing lines Coverage Δ
host.go 63.85% <100.00%> (-1.81%) ⬇️

... and 3 files with indirect coverage changes

@Kubuxu Kubuxu added this pull request to the merge queue Oct 28, 2024
Merged via the queue into filecoin-project:main with commit 23ff5de Oct 28, 2024
11 checks passed
@hanabi1224 hanabi1224 deleted the hm/demote-log-skip-cert branch October 28, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants