Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probably fix #5096 #5111

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Probably fix #5096 #5111

merged 2 commits into from
Oct 14, 2024

Commits on Oct 11, 2024

  1. Assure tests don't assume the default branch is set to master globa…

    …lly.
    
    Unfortunately, with anything `git2`, it's impossible (or unknown) to
    prevent it from picking up the users configuration, hence tests aren't
    isolated.
    
    This change alleviates the worst results of this which at least makes
    the tests run in my particular setup.
    Byron committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    b58a3f6 View commit details
    Browse the repository at this point in the history
  2. Assure that Project::path can be compared reasonably with other pat…

    …hs (gitbutlerapp#5096)
    
    When testing paths for prefix-matches it's important they are all normalized in
    the same fashion.
    
    `canonicalize()` is very particular about canonicalizing Windows paths, which
    makes it easy for these paths to not be compatible to other absolute-looking
    paths.
    
    The difficulty here is to get the right trade-off between performance and
    safety, e.g. we wouldn't want these canonicalized Windows paths to be used
    anywhere as they are very uncommon (and don't even work everywhere).
    Byron committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d63babf View commit details
    Browse the repository at this point in the history