feat(bigtable): Add MarshalJSON to allow clients to get a stringified version of the protobuf #10679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion of the protobuf
product-auto-label
bot
added
the
api: bigtable
codyoss
reviewed
Aug 13, 2024
codyoss
reviewed
Aug 13, 2024
ron-gal
changed the title
bigtable/type_test.go
Outdated
| if !proto.Equal(got, want) { | ||
| t.Errorf("got type %v, want: %v", got, want) | ||
| wantJSON := "{\"stringType\":{\"encoding\":{\"utf8Raw\":{}}}}" | ||
| if strings.ReplaceAll(string(gotJSON), " ", "") != wantJSON { |
There was a problem hiding this comment.
rather than testing that the json equals a known string, I think we can instead just test that round tripping the object from json and back yield the "correct" thing? Comparing json strings has the potential for false errors.
bigtable/type.go
Outdated
|
|
||
| // Type wraps the protobuf representation of a type. See the protobuf definition | ||
| // for more details on types. | ||
| type Type interface { | ||
| proto() *btapb.Type | ||
| } | ||
|
|
||
| var marshalOptions = protojson.MarshalOptions{AllowPartial: true, UseEnumNumbers: true} | ||
| var unmarshalOptions = protojson.UnmarshalOptions{AllowPartial: true, DiscardUnknown: true} |
There was a problem hiding this comment.
I dont think we want DiscardUnknown? assuming that does what it sounds like.
steveniemitz
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.