-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigtable): Add MarshalJSON to allow clients to get a stringified version of the protobuf #10679
Merged
Merged
feat(bigtable): Add MarshalJSON to allow clients to get a stringified version of the protobuf #10679
Changes from 15 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
cdb5ed1
feat(bigtable): Add ToJson to allow clients to get a stringified vers…
ron-gal 414025d
minor rename
ron-gal 7d6296b
minor test fix
ron-gal a38d6aa
minor rename
ron-gal c51a7ce
use MarshalJSON instead
ron-gal 7ebf952
use shared marshal options
ron-gal d9a64f6
Merge branch 'googleapis:main' into add_to_json
ron-gal 95736c6
Force Type implementors to implement MarshalJSON
ron-gal b51320a
add UnmarshalJSON and Equal
ron-gal ec62cd3
add UnmarshalJSON and Equal
ron-gal c46e6ac
Merge branch 'main' into add_to_json
ron-gal 73c63c3
fix equality comparison
ron-gal 3bf1e5f
fix todo
ron-gal 6a9df2e
simplify solution
ron-gal 48bc78d
simplify solution
ron-gal 021b352
remove json string comparison
ron-gal 0f4cbd1
Merge branch 'main' into add_to_json
ron-gal beae3d6
Improve tests
ron-gal f0830fc
Merge branch 'main' into add_to_json
ron-gal 27cff35
Merge branch 'main' into add_to_json
ron-gal 71deb0d
Type
ron-gal 9e78293
Type
ron-gal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we want DiscardUnknown? assuming that does what it sounds like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done