test(storage): add WriteTo integration test cases #9681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the most important integration tests for Reader to cover both Read and WriteTo. Also remove refs to deprecated ioutil.
product-auto-label
bot
added
the
api: storage
BrennaEpp
approved these changes
Apr 2, 2024
Comment on lines
+4556
to
+4571
| // Check early close. | ||
| buf := make([]byte, 1) | ||
| rc, err = b.Object(obj).NewReader(ctx) | ||
| if err != nil { | ||
| t.Fatalf("%v: %v", obj, err) | ||
| } | ||
| _, err = rc.Read(buf) | ||
| if err != nil { | ||
| t.Fatalf("%v: %v", obj, err) | ||
| } | ||
| if got, want := buf, contents[obj][:1]; !bytes.Equal(got, want) { | ||
| t.Errorf("Contents[0] (%q) = %q; want %q", obj, got, want) | ||
| } | ||
| if err := rc.Close(); err != nil { | ||
| t.Errorf("%v Close: %v", obj, err) | ||
| } |
There was a problem hiding this comment.
Suggestion: Can this be moved out one level? I don't think we need to test this for both read funcs.
There was a problem hiding this comment.
I think it's fine to leave it as is; it doesn't shrink the test matrix at all to make this change.
tritone
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the most important integration tests for Reader to cover both Read and WriteTo.
Also remove refs to deprecated ioutil.