Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return block hash for eth_getTransactionReceipt #122

Merged
merged 2 commits into from
Sep 18, 2023
Merged

fix: return block hash for eth_getTransactionReceipt #122

merged 2 commits into from
Sep 18, 2023

Conversation

nbaztec
Copy link
Contributor

@nbaztec nbaztec commented Sep 18, 2023

What 💻

  • Fixes incorrect behavior for eth_getTransactionReceipt where it'd return tx hash instead of block hash for the field block_hash

Why ✋

  • Fixes incorrect behavior

Evidence 📷

image

Notes 📝

@nbaztec nbaztec requested a review from a team as a code owner September 18, 2023 12:39
@MexicanAce MexicanAce changed the title bugfix: return block hash for eth_getTransactionReceipt fix: return block hash for eth_getTransactionReceipt Sep 18, 2023
MexicanAce
MexicanAce approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@MexicanAce MexicanAce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MexicanAce MexicanAce merged commit 599758f into matter-labs:main Sep 18, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MexicanAce MexicanAce MexicanAce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

eth_getTransactionReceipt is not returning the correct block_hash
2 participants
@nbaztec @MexicanAce