Fix DataRow issues related to serialization/deserialization #4078
+101
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Youssef1313
commented
Nov 18, 2024
| @@ -28,6 +29,8 @@ public sealed class TestMethod : ITestMethod | |||
| private string? _declaringClassFullName; | |||
| private string? _declaringAssemblyName; | |||
|
|
|||
| private static readonly ConcurrentDictionary<string, object?[]> DataDictionary = new(); | |||
There was a problem hiding this comment.
Notes:
- This is bad. The dictionary in theory can grow up indefinitely.
- Currently, UniqueName isn't really unique and we need a better mechanism here. One possibility is to attach a test property resulting from
Interlocked.Incrementon a static counter and use that as the dictionary key. Then, instead of deserializing we look up that key. - This PR is mostly to open a discussion about the possibilities to improve the situation for some parameterized tests broken scenarios.
@Evangelink thoughts? I feel like some of the parameterized test issues could be fixable without the need for breaking changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.