-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DataRow issues related to serialization/deserialization #4078
Draft
Youssef1313
wants to merge
1
commit into
microsoft:main
Choose a base branch
from
Youssef1313:improve-datarow-issues-serialization
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73 changes: 73 additions & 0 deletions
73
test/IntegrationTests/MSTest.Acceptance.IntegrationTests/DataRowTests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
// Copyright (c) Microsoft Corporation. All rights reserved. | ||
// Licensed under the MIT license. See LICENSE file in the project root for full license information. | ||
|
||
using Microsoft.Testing.Platform.Acceptance.IntegrationTests; | ||
using Microsoft.Testing.Platform.Acceptance.IntegrationTests.Helpers; | ||
using Microsoft.Testing.Platform.Helpers; | ||
|
||
namespace MSTest.Acceptance.IntegrationTests; | ||
|
||
[TestGroup] | ||
public class DataRowTests : AcceptanceTestBase | ||
{ | ||
private const string SourceCode = """ | ||
#file DataSourceTests.csproj | ||
<Project Sdk="Microsoft.NET.Sdk"> | ||
<PropertyGroup> | ||
<TargetFramework>$TargetFramework$</TargetFramework> | ||
<ImplicitUsings>enable</ImplicitUsings> | ||
<OutputType>Exe</OutputType> | ||
<LangVersion>preview</LangVersion> | ||
<EnableMSTestRunner>true</EnableMSTestRunner> | ||
</PropertyGroup> | ||
<ItemGroup> | ||
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="$MicrosoftNETTestSdkVersion$" /> | ||
<PackageReference Include="MSTest.TestAdapter" Version="$MSTestVersion$" /> | ||
<PackageReference Include="MSTest.TestFramework" Version="$MSTestVersion$" /> | ||
</ItemGroup> | ||
</Project> | ||
|
||
#file MyTestClass.cs | ||
using Microsoft.VisualStudio.TestTools.UnitTesting; | ||
|
||
[TestClass] | ||
public class MyTestClass | ||
{ | ||
[DataTestMethod] | ||
[DataRow((byte)0, new object[] { (byte)0 })] | ||
[DataRow((short)0, new object[] { (short)0 })] | ||
[DataRow((long)0, new object[] { (long)0 })] | ||
public void CheckNestedInputTypes(object org, object nested) | ||
{ | ||
Assert.AreEqual(org.GetType(), (((object[])nested)[0].GetType())); | ||
} | ||
} | ||
"""; | ||
|
||
private readonly AcceptanceFixture _acceptanceFixture; | ||
|
||
public DataRowTests(ITestExecutionContext testExecutionContext, AcceptanceFixture acceptanceFixture) | ||
: base(testExecutionContext) => _acceptanceFixture = acceptanceFixture; | ||
|
||
public async Task TestDataRowNumericalInArrayDoesNotLoseOriginalType() | ||
{ | ||
using TestAsset generator = await TestAsset.GenerateAssetAsync( | ||
"DataRowTests", | ||
SourceCode | ||
.PatchCodeWithReplace("$MSTestVersion$", MSTestVersion) | ||
.PatchCodeWithReplace("$MicrosoftNETTestSdkVersion$", MicrosoftNETTestSdkVersion) | ||
.PatchCodeWithReplace("$TargetFramework$", TargetFrameworks.NetCurrent.Arguments), | ||
addPublicFeeds: true); | ||
|
||
await DotnetCli.RunAsync( | ||
$"build {generator.TargetAssetPath} -c Release", | ||
_acceptanceFixture.NuGetGlobalPackagesFolder.Path, | ||
retryCount: 0); | ||
|
||
var testHost = TestHost.LocateFrom(generator.TargetAssetPath, "DataSourceTests", TargetFrameworks.NetCurrent.Arguments); | ||
|
||
TestHostResult result = await testHost.ExecuteAsync(); | ||
result.AssertExitCodeIs(ExitCodes.Success); | ||
result.AssertOutputContainsSummary(failed: 0, passed: 3, skipped: 0); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notes:
Interlocked.Increment
on a static counter and use that as the dictionary key. Then, instead of deserializing we look up that key.@Evangelink thoughts? I feel like some of the parameterized test issues could be fixable without the need for breaking changes?