Refactor to use a std::pair to hold factor index and axis refs. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_696112797
branch
from
c7c3f39
to
195834b
Compare
copybara-service
bot
changed the title
This simplifies the logic a bit, and aligns better with the algorithm which picks the factor-axes pair with the largest count at each iteration. Also prepares a different implementation that keeps a mapvector of factor-axes pairs and treverses the vector in the non-increasing order of their counts. PiperOrigin-RevId: 696463524
copybara-service
bot
force-pushed
the
test_696112797
branch
from
195834b
to
7549f48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor to use a std::pair to hold factor index and axis refs.
This simplifies the logic a bit, and aligns better with the algorithm which picks the factor-axes pair with the largest count at each iteration. Also prepares a different implementation that keeps a mapvector of factor-axes pairs and treverses the vector in the non-increasing order of their counts.