Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use a std::pair to hold factor index and axis refs. #200

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Refactor to use a std::pair to hold factor index and axis refs. #200

merged 1 commit into from
Nov 14, 2024

Commits on Nov 14, 2024

  1. Refactor to use a std::pair to hold factor index and axis refs. 

    This simplifies the logic a bit, and aligns better with the algorithm which picks the factor-axes pair with the largest count at each iteration. Also prepares a different implementation that keeps a mapvector of factor-axes pairs and treverses the vector in the non-increasing order of their counts.

PiperOrigin-RevId: 696463524
    @Google-ML-Automation @copybara-github
    Google-ML-Automation authored and copybara-github committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    7549f48 View commit details
    Browse the repository at this point in the history