-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk): Add NodePrimitives::BlockHeader
and NodePrimitives::BlockBody
#12647
base: emhane/maybe-compact
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm, why do we need this if the header and body type are already defined in the block type?
it makes it a lot easier to access the header type...one could argue the same about signed transaction too otherwise |
I suspect this would make things harder when enforcing bounds because then we need to restrict don't think we should do this |
we have the same problem with signed tx, must be restricted to |
I don't see why this is a problem when |
Merge commits are not allowed on this repository
25b4177
to
abd6bdc
Compare
can't figure out what's wrong with the features here https://github.com/paradigmxyz/reth/actions/runs/11921032967/job/33224297145?pr=12647 |
Based on #12683
Ref #12358