Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): Add NodePrimitives::BlockHeader and NodePrimitives::BlockBody #12647

Open
wants to merge 27 commits into
base: emhane/maybe-compact
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
b5a88b5
Make Chain generic over data primitives
emhane Nov 17, 2024
01ec336
Merge branch 'main' into emhane/chain-generic-prims
emhane Nov 18, 2024
72d4b4c
Remove redundant AnyPrimitives
emhane Nov 18, 2024
f305a13
Add NodePrimitives::BlockHeader and NodePrimitives::BlockBody
emhane Nov 19, 2024
680765e
Merge branch 'emhane/chain-generic-prims' into emhane/node-prims-bloc…
emhane Nov 19, 2024
3ca1964
Merge branch 'main' into emhane/chain-generic-prims
emhane Nov 19, 2024
076aeb2
Merge branch 'emhane/chain-generic-prims' into emhane/node-prims-bloc…
emhane Nov 19, 2024
c93fb43
Move OpPrimitives to reth-optimism-primitives
emhane Nov 19, 2024
0fe0050
Use OpPrimitives in test
emhane Nov 19, 2024
660e4c6
Fix lint
emhane Nov 19, 2024
9c44d16
Merge branch 'main' into emhane/node-prims-block-parts
emhane Nov 19, 2024
13c3463
Merge branch 'main' into emhane/op-prims
emhane Nov 19, 2024
85f7ee1
Merge branch 'emhane/op-prims' into emhane/node-prims-block-parts
emhane Nov 19, 2024
424c270
Merge branch 'main' into emhane/node-prims-block-parts
emhane Nov 19, 2024
48b1ab3
Link FullNodePrimitives::BlockBody and FullNodePrimitives::BlockHeader
emhane Nov 19, 2024
a1458ef
Merge branch 'main' into emhane/node-prims-block-parts
emhane Nov 19, 2024
bac2f0b
Fix merge conflicts
emhane Nov 19, 2024
47badb2
Fix merge conflicts op
emhane Nov 19, 2024
faa86ae
Remove Compact trait bound on FullSignedTx in accordance with Transac…
emhane Nov 19, 2024
f65fb6d
Fix merge conflicts by introducing helper triat MaybeCompact
emhane Nov 19, 2024
dfd285f
Merge branch 'emhane/maybe-compact' into emhane/node-prims-block-parts
emhane Nov 19, 2024
f6ccb05
Merge branch 'emhane/maybe-compact' into emhane/node-prims-block-parts
emhane Nov 19, 2024
bb6c040
Add no_std support for reth-optimism-primitives
emhane Nov 19, 2024
abd6bdc
Fix deps
emhane Nov 19, 2024
55c6f3c
Fix deps
emhane Nov 19, 2024
350974f
Fix deps
emhane Nov 19, 2024
1dd5939
Fix deps
emhane Nov 19, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
79 changes: 38 additions & 41 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 2 additions & 14 deletions crates/ethereum/node/src/node.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@ use reth_evm::execute::BasicBlockExecutorProvider;
use reth_evm_ethereum::execute::EthExecutionStrategyFactory;
use reth_network::{NetworkHandle, PeersInfo};
use reth_node_api::{
AddOnsContext, ConfigureEvm, EngineValidator, FullNodeComponents, NodePrimitives,
NodeTypesWithDB,
AddOnsContext, ConfigureEvm, EngineValidator, FullNodeComponents, NodeTypesWithDB,
};
use reth_node_builder::{
components::{
Expand All @@ -26,7 +25,7 @@ use reth_node_builder::{
BuilderContext, Node, NodeAdapter, NodeComponentsBuilder, PayloadBuilderConfig, PayloadTypes,
};
use reth_payload_builder::{PayloadBuilderHandle, PayloadBuilderService};
use reth_primitives::{Block, Receipt, TransactionSigned, TxType};
use reth_primitives::EthPrimitives;
use reth_provider::CanonStateSubscriptions;
use reth_rpc::EthApi;
use reth_tracing::tracing::{debug, info};
Expand All @@ -38,17 +37,6 @@ use reth_trie_db::MerklePatriciaTrie;

use crate::{EthEngineTypes, EthEvmConfig};

/// Ethereum primitive types.
#[derive(Debug, Default, Clone)]
pub struct EthPrimitives;

impl NodePrimitives for EthPrimitives {
type Block = Block;
type SignedTx = TransactionSigned;
type TxType = TxType;
type Receipt = Receipt;
}

/// Type configuration for a regular Ethereum node.
#[derive(Debug, Default, Clone, Copy)]
#[non_exhaustive]
Expand Down
Loading