Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added interface with qrix-motion plc. Copied changes to SampleChamber logic from PR15. INTERLOCKS STILL NEED TO BE PROGRAMMED, ONLY INTERFACE WAS ADDED. #16

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

NSLentz
Copy link
Contributor

@NSLentz NSLentz commented Mar 19, 2024

Description

Added interface with qrix-motion plc. Copied changes to SampleChamber logic from PR15. Defined signals to be exchanged and added some variables to allow the signals to be linked to the plc code. Copied changes to PRG_SampleChamber.TcPOU from PR15 from Maggie.

Motivation and Context

How Has This Been Tested?

Where Has This Been Documented?

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

… qrix-motion plc. Defined signals to be exchanged and added some variables to allow the signals to be linked to the plc code. Copied changes to PRG_SampleChamber.TcPOU from PR15 from Maggie.
@NSLentz NSLentz requested a review from ghalym March 19, 2024 18:28
Copy link
Collaborator

@ghalym ghalym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ghalym ghalym merged commit 09f3fdd into pcdshub:master Mar 19, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants