fix: Better detection of initial state #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pdModal is not stored in the state if it is the initial state created in Naja's `replaceInitialState`. After the Naja update to 2.6.0 it is easier to detect the initial state and prevent the `pdModal` from being saved in it. This is especially helpful when a non-ajax modal is opened and then navigated. Previously, this was incorrectly detected as a PdModal state because PdModal was already open. Now, in this case, the state correctly contains no `pdModal`, as the non-ajax modal should never appear in the history (and if it does, it shouldn't be handled by the `AjaxModalExtension` anyway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pdModal is not stored in the state if it is the initial state created in Naja's
replaceInitialState. After the Naja update to 2.6.0 it is easier to detect the initial state and prevent thepdModalfrom being saved in it. This is especially helpful when a non-ajax modal is opened and then navigated. Previously, this was incorrectly detected as a PdModal state because PdModal was already open. Now, in this case, the state correctly contains nopdModal, as the non-ajax modal should never appear in the history (and if it does, it shouldn't be handled by theAjaxModalExtensionanyway).