feature: Spinners are preserved during redirects #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the request ends in redirect, the spinners (and button spinners) are not removed. As the options are copied to the new (redirect) request, we only remove the `spinnerInitiator` and `btnSpinnerInitiator` fields so that the spinners are not duplicated. Once the redirect is complete, the spinners will be removed as the `spinnerQueue` and `btnSpinner` have been preserved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the request ends in redirect, the spinners (and button spinners) are not removed. As the options are copied to the new (redirect) request, we only remove the
spinnerInitiatorandbtnSpinnerInitiatorfields so that the spinners are not duplicated. Once the redirect is complete, the spinners will be removed as thespinnerQueueandbtnSpinnerhave been preserved.