Develop #6
Merged
Develop #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
approved these changes
Jul 9, 2020
| @@ -5,7 +5,7 @@ public protocol XRayEmitter { | |||
| func flush(_ callback: @escaping (Error?) -> Void) | |||
| } | |||
|
|
|||
| public struct XRayNoopEmitter: XRayEmitter { | |||
| public struct XRayNoOpEmitter: XRayEmitter { | |||
There was a problem hiding this comment.
;-) previous PR was more juicy, in fact should have been divided int osmaller ones
the examples gsoc-swift-tracing look nice, let me follow up on that in slashmo/gsoc-swift-tracing#36
There was a problem hiding this comment.
:-)
There's a WIP towards defining protocols for tracer instruments here (following open telemetry shape of API mostly): which may be of interest to you btw: slashmo/gsoc-swift-tracing#62
Thanks in advance, really looking forward to soon trying out xray with it the APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.