-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop #6
Merged
Develop #6
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
import Logging | ||
|
||
import struct Foundation.Data | ||
import class Foundation.JSONEncoder | ||
|
||
private extension JSONEncoder { | ||
func encode<T: Encodable>(_ value: T) throws -> String { | ||
String(decoding: try encode(value), as: UTF8.self) | ||
} | ||
} | ||
|
||
// TODO: document | ||
|
||
public struct XRayLogEmitter: XRayEmitter { | ||
private let logger: Logger | ||
|
||
private let encoder: JSONEncoder = { | ||
let encoder = JSONEncoder() | ||
encoder.outputFormatting = .prettyPrinted | ||
return encoder | ||
}() | ||
|
||
public init(label: String? = nil) { | ||
let label = label ?? "xray.log_emitter.\(String.random32())" | ||
logger = Logger(label: label) | ||
} | ||
|
||
public func send(_ segment: XRayRecorder.Segment) { | ||
do { | ||
let document: String = try encoder.encode(segment) | ||
logger.info("\n\(document)") | ||
} catch { | ||
logger.error("Failed to encode a segment: \(error)") | ||
} | ||
} | ||
|
||
public func flush(_: @escaping (Error?) -> Void) {} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
;-) previous PR was more juicy, in fact should have been divided int osmaller ones
the examples
gsoc-swift-tracing
look nice, let me follow up on that in slashmo/gsoc-swift-tracing#36There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:-)
There's a WIP towards defining protocols for tracer instruments here (following open telemetry shape of API mostly): which may be of interest to you btw: slashmo/gsoc-swift-tracing#62
Thanks in advance, really looking forward to soon trying out xray with it the APIs.