Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024Q4] Christmas Shop #1713

Merged
merged 14 commits into from
Oct 22, 2024
Merged

Conversation

WiiJoy
Copy link
Collaborator

@WiiJoy WiiJoy commented Oct 12, 2024

Add a task "Christmas Shop"

🤔 This is a ...

  • 🌟 New task
  • 🌐 New module
  • ⚙️ Update to an existing task
  • 🔧 Update to an existing module
  • 🔗 Update or addition of external resources or links
  • 🐛 Fix in a task or related content
  • 🛠 Fix in a module or related content
  • ✏️ Fixed a typo or grammatical error
  • 🔗 Fixed a broken link
  • ❓ Other (specify: ****____****)

Description

  • Brief Overview: Add a task "Christmas Shop"
  • Implementation Approach: ---

Additional Information

  • Screenshots/Links:
    image

  • Related Issues:

Checklist

  • ✅ I have performed a self-review of my own code.
  • 📝 I have commented my code, particularly in hard-to-understand areas.
  • 🔧 I have made corresponding changes to the documentation (if applicable).
  • 🚫 My changes generate no new warnings or errors.

@WiiJoy WiiJoy added the stage#1 label Oct 12, 2024
- Valid markup of checked page corresponds to the message _"Document checking completed. No errors or warnings to show."_ In this case, we assign the full points for the checked page (+6).
- If there are `warnings` but no `errors`, we assign half of the points (+3) for the checked page
- Favicon is added to each page: **+2**
- Each page has only one `<h1>` element: **+2**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one <h1> per each page
Чтобы избежать недопонимания и срезаний оценок


### Penalties

1. The layout of the entire design or individual blocks is implemented using images.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The layout of the entire design or individual blocks is implemented using images, except in cases where the image is specifically required by the design.

## DevTools Responsiveness Check Details

1. To open Developer Tools:
- Press the `F12` key, or right-click and choose the `View Source` option in the context menu;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and choose the Inspect


- Task should be done in private school's repository. [How to work with a school's private repository](https://docs.rs.school/#/private-repository)
- Create new branch `christmas-shop` from `main`. Create a folder `christmas-shop` in the created branch. Place your code in this folder.
- The `main` (or `master`) branch should be empty (contain only files like README.md, .gitignore or .github folder)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- The `main` (or `master`) branch should be empty (contain only files like README.md, .gitignore or .github folder)
- The `main` branch should be empty (contain only files like README.md, .gitignore or .github folder)

Школьные репозитории создаются из шаблона, в котором основная ветка названа main


- Log in to [Figma](https://www.figma.com/);
- Open the layout;
- On the top panel, click on the arrow next to the layout name, and select the option "Duplicate to your drafts";
Copy link
Contributor

@bastaynav bastaynav Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В фигме вышло обновление и теперь этот пункт не сверху, а в дропдауне в панели слева
https://help.figma.com/hc/en-us/articles/23954856027159-Navigating-UI3-Figma-s-new-UI#:~:text=File%20name%2C%20project%20name%2C%20and%20file%20actions
Возможность вернутся назад есть, но я не уверен, что новый интерфейс не включен по-умолчанию для новых пользователей

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Новый интерфейс, кажется, все же открывается по умолчанию

Co-authored-by: Meg G. <146496794+stardustmeg@users.noreply.github.com>
@WiiJoy WiiJoy merged commit 0487a7c into rolling-scopes-school:master Oct 22, 2024
1 check passed
@WiiJoy WiiJoy deleted the christmas-shop branch October 31, 2024 16:32
- When clicking the cross, the burger menu smoothly hides, moving to the right of the screen, and the cross smoothly transforms into a burger icon: **+4**
- The burger icon is created using HTML and CSS without the use of images/svg: **+2**
- Links in the burger menu work, providing smooth scrolling to anchor points: **+2**
- When clicking on any link (interactive or non-interactive) in the menu, the burger menu smoothly hides to the right, and the cross smoothly transforms into a burger icon: **+2**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

клик по неинтерактивному элементу приводит к какому-то действию? он же неинтерактивный 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants