Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024Q4] Christmas Shop #1713

Merged
merged 14 commits into from
Oct 22, 2024
98 changes: 98 additions & 0 deletions tasks/christmas-shop/christmas-shop-part1.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
## Christmas Shop. Part-1 - Fixed Layout

### Main Task Description and Requirements

- [Detailed Description](christmas-shop.md)

You need to create `Home` and `Gifts` pages according to the [Design in Figma](https://www.figma.com/design/zTB01BwWZVoXYK5atH3eZT/Cristmas-Shop) - only **Home / w1440** and **Gifts / w1440**.
The content width of 1440px should not change when resizing the browser window.

## Workflow

1. The task should be completed in private repository of the school. [How to work with a school's private repository](https://docs.rs.school/#/private-repository)
2. Create a new branch named `christmas-shop` from `main` branch. Create a folder `christmas-shop` in the created branch. Place your code in this folder.
3. Complete the task.
4. Ensure your work meets the [CrossCheck Criteria](#crosscheck-criteria).
5. Independently evaluate your work according to the provided [Criteria for Evaluation](#criteria-for-evaluation), keeping in mind the [Specifics of Verifying Layout](#specifics-of-verifying-layout).
6. Deploy your work to gh-pages. For example, create and merge a Pull Request from the `christmas-shop` branch into `gh-pages` branch. The title of the Pull Request can be chosen at your discretion. A description for this Pull Request is not necessary.
7. Once you have completed your work, open a Pull Request from the `christmas-shop` branch to the `main` branch. Give the Pull Request a title based on the task name. Provide a description for the Pull Request following [template](https://docs.rs.school/#/pull-request-review-process?id=ВрСбования-ΠΊ-pull-request-pr).
There is no need to merge this Pull Request.
8. Submit the deployment link of your project in the "Cross-Check Submit" section of the [RS APP](https://app.rs.school/).
9. After the task deadline has passed, the cross-check phase will start, lasting three days. To earn points for the task, you must review all the projects assigned to you for cross-checking and submit your review results in the "Cross-Check Review" section of the [RS APP](https://app.rs.school/).

### CrossCheck Criteria (110 points)

1. Checking validation of pages: **+18**
- The layout for both pages is validated and error-free according to the W3C Validator (https://validator.w3.org/): **+12** (6 points per page)
- Valid markup of checked page corresponds to the message _"Document checking completed. No errors or warnings to show."_ In this case, we assign the full points for the checked page (+6).
- If there are `warnings` but no `errors`, we assign half of the points (+3) for the checked page
- Favicon is added to each page: **+2**
- Only one `<h1>` per each page: **+2**
- The URL of the `Gifts` page differs from the URL of the `Home` page (e.g. `your-site.com` for the `Home` page and `your-site.com/gifts` for the `Gifts` page): **+2**
2. The layout matches the design: **+46**
- `<header>` on each page: **+4**
- `Hero` section on `Home` page: **+6**
- `About` section on `Home` page: **+6**
- `Slider` section on `Home` page: **+6**
- `Best Gifts` section on `Home` page: **+6**
- `CTA` section on `Home` page: **+6**
- `Gifts` section on `Gifts` page: **+6**
- `<footer>` on each page: **+6**
3. CSS Requirements: **+10**
- For positioning gifts in `Best Gifts` section on `Home` page and gifts in `Gifts` section on `Gifts` page used **Flexbox** or **Grid Layout**: **+4**
- When scaling the browser page (<100%) or increasing the page width (>1440px), the layout of both pages is centered rather than shifted to the side and not stretched across the entire width: **+4**
- The empty spaces around the layout are filled with white color: **+2**
4. Interactivity: **+36**
- Navigation elements (except `CONTACTS`) lead to corresponding sections on `Home` page: **+4**
- `CONTACTS` in navigation panel links to the `<footer>` on its own page: **+2**
- Smooth scrolling with anchor links: **+2**
- When clicking on the **GIFTS** link in `<header>` and **Explore Magical Gifts** button in `Hero` and `CTA` sections on `Home` page, it navigates to the `Gifts` page: **+2**
- The **GIFTS** link in `<header>` on `Gifts` page is non-interactive and don't have a hover effects: **+2**
- When clicking on the **Logo** in `<header>`, it navigates to the `Home` page: **+2**
- The active **ALL** tab in `Gifts` section of `Gifts` page is non-interactive and don't have a hover effects: **+2**
- Each Gift-card in the `Gifts` section of the `Gifts` page, `Best Gifts` section on `Home` page and cards in `<footer>` is interactive when hovering over any area of the card: **+6**
- In the `<footer>`, clicking on the card **CALL US** should initiate a phone call: **+2**
- In the `<footer>`, clicking on the card **WRITE US** should open the mail client: **+2**
- In the `<footer>`, clicking on the card **MAGIC FOREST** should open a new browser tab with Google Maps displaying any location of your choice: **+2**
- In the `<footer>`, clicking on the link **Made in Rolling Scopes School** should open the [school's website](https://rs.school/) in a new tab: **+2**
- Interactivity of links and buttons is implemented according to Figma layout. Interactivity includes not only changing cursor's appearance, for example, using the `cursor: pointer` property, but also the use of other visual effects, such as changing the background color or font color, following the **Styleguide** in Figma layout: **+4**
- Mandatory requirement for interactivity: smooth change in the appearance of an element on hover, without affecting adjacent elements: **+4**

### Penalties

1. The layout of the entire design or individual blocks is implemented using images, except in cases where the image is specifically required by the design.
2. The use of frameworks, libraries, and technologies that are prohibited in the [Technical Requirements](./christmas-shop.md#technical-requirements).
muannna marked this conversation as resolved.
Show resolved Hide resolved

## Criteria for Evaluation

**Maximum score for the task: 110 points**

The scoring for each requirement is detailed in the [CrossCheck Criteria](#crosscheck-criteria) section.

Any disputed issues should be resolved in favor of the student being assessed.

## Specifics of Verifying Layout

- A deviation of up to 10px horizontally and vertically from the layout is permissible as long as visual congruity between the design and the markup is preserved.
- Utilize the [PerfectPixel](https://chrome.google.com/webstore/detail/perfectpixel-by-welldonec/dkaagdgjmgdmbnecmcefdhjekcoceebi?hl=ru) Chrome extension to verify alignment with the design.
- When using the PerfectPixel extension, ensure it is set to a scale factor of 1, and that your browser and operating system are set to 100% scale.
- If the screen resolution is greater than 1440 pixels, to check for compliance with the layout, it is sufficient to center horizontally the layout or manually align it with the top-left corner guides.
- If the screen resolution is 1440 pixels or less, use the device toolbar in Google Chrome browser in responsive mode for checking.
- Please note that when checking the work in a window with a width of 1440 pixels, the layout may compress by approximately 17 pixels. This happens because part of the layout space is consumed by the vertical scroll (17 pixels - the standard scroll size for Google Chrome).
- Each block and section should be evaluated independently; deficiencies in one block should not affect the assessment of subsequent blocks. Start each new block's review with it aligned to the overlaid layout from PerfectPixel.
- For text, check its alignment and spacing within the confines of the block. Text sizes should be checked only for their height. Variations in word width and letter spacing are not considered errors as long as the correct font with specified properties is used.

## How to Submit

- **Christmas Shop. Part-1 - Fixed Layout** task is evaluated through a cross-check process.
- Upon receipt of the task and prior to the submission deadline, proceed to the RS App at https://app.rs.school/. Navigate to **Cross-Check: Submit**, select the appropriate task from the dropdown list, and enter the URL of your deployed website into the **Solution URL** field. Then click the **Submit** button.

## Submit Recommendations

- Aim to submit early once the submission option becomes available in the RS App. You are free to make additional changes up until the deadline.
- Given that the project is contained within a private repository, there's no need to share repository or pull request links as reviewers will not have access to them. Private repositories are visible only to you, the course administrators, and any assigned mentors.
- Verify that the deployed website link is functional, especially when accessed in the browser's incognito mode.

## Task Evaluation

- Follow the instructions for conducting a cross-check available at: https://docs.rs.school/#/cross-check-flow
129 changes: 129 additions & 0 deletions tasks/christmas-shop/christmas-shop-part2.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,129 @@
## Christmas Shop. Part-2 - Responsive Design

### Main Task Description and Requirements

- [Detailed Description](christmas-shop.md)

In this part of the task, we will adapt the previously created pages (**Home** and **Gifts**) for tablets and mobile devices.
The goal is to match the layout with the corresponding [Design in Figma](https://www.figma.com/design/zTB01BwWZVoXYK5atH3eZT/Cristmas-Shop) at screen resolutions of 1440px, 768px, and 380px.
The choice of breakpoints and their number is left to the student's discretion.
For all other resolutions up to 380px, ensure:

- There is no horizontal scrollbar.
- The layout is adaptive and responsive.
- All page content is preserved.
- Image proportions are maintained.
- No white spaces are present to the right of the sections.

To make responsive design, use relative units of measurement (%, rem, vh, etc).

## Workflow

1. The task should be completed in private repository of the school. [How to work with a school's private repository](https://docs.rs.school/#/private-repository).
2. Create a new branch named `christmas-shop-part2` from the `christmas-shop` branch. You will find the `christmas-shop` folder containing the project files completed in the previous stage within this branch.
3. Continue working on the task within the branch you have created.
4. Ensure your work meets the [CrossCheck Criteria](#crosscheck-criteria).
5. Independently evaluate your work according to the provided [Criteria for Evaluation](#criteria-for-evaluation), keeping in mind the [DevTools Responsiveness Check Details](#devtools-responsiveness-check-details) and the [Specifics of Verifying Layout](#specifics-of-verifying-layout).
6. Create a Pull Request from the `christmas-shop-part2` branch to the `christmas-shop` branch, resolve any conflicts that arise, and then merge the Pull Request.
The title of the Pull Request can be chosen at your discretion. A description for this Pull Request is not necessary.
7. After completing the cross-check for the previous part of the task, update your project's deployment. For example, you can create and merge a Pull Request from the `christmas-shop` branch to the `gh-pages` branch.
The title of the Pull Request can be chosen at your discretion. A description for this Pull Request is not necessary.
8. Once you have completed your work, update the Pull Request from the `christmas-shop` branch to the `main` branch to include the newly added functionality from the second part of the task.
It is not required to merge this Pull Request.
9. Submit the deployment link of your project in the "Cross-Check Submit" section of the [RS APP](https://app.rs.school/).
10. After the task deadline has passed, the cross-check phase will start, lasting three days. To earn points for the task, you must review all the projects assigned to you for cross-checking and submit your review results in the "Cross-Check Review" section of the [RS APP](https://app.rs.school/).

### CrossCheck Criteria (100 points)

1. The layout of the pages aligns the design at a screen width of 1440px: **+16**
- `<header>` on each page: **+2**
- `Hero` section on `Home` page: **+2**
- `About` section on `Home` page: **+2**
- `Slider` section on `Home` page: **+2**
- `Best Gifts` section on `Home` page: **+2**
- `CTA` section on `Home` page: **+2**
- `Gifts` section on `Gifts` page: **+2**
- `<footer>` on each page: **+2**
2. The layout of the pages aligns the design at a screen width of 768px: **+16**
- `<header>` on each page: **+2**
- `Hero` section on `Home` page: **+2**
- `About` section on `Home` page: **+2**
- `Slider` section on `Home` page: **+2**
- `Best Gifts` section on `Home` page: **+2**
- `CTA` section on `Home` page: **+2**
- `Gifts` section on `Gifts` page: **+2**
- `<footer>` on each page: **+2**
3. The layout of the pages aligns the design at a screen width of 380px: **+16**
- `<header>` on each page: **+2**
- `Hero` section on `Home` page: **+2**
- `About` section on `Home` page: **+2**
- `Slider` section on `Home` page: **+2**
- `Best Gifts` section on `Home` page: **+2**
- `CTA` section on `Home` page: **+2**
- `Gifts` section on `Gifts` page: **+2**
- `<footer>` on each page: **+2**
4. There is no horizontal scrollbar at all screen width up to 380px inclusive. All page content remains as per the design: it is not cropped, removed, or shifted to the side: **+24**
- `Home` page: no horizontal scroll bar between 1440px and 768px widths: **+6**
- `Home` page: no horizontal scroll bar between 768px and 380px widths: **+6**
- `Gifts` page: no horizontal scroll bar between 1440px and 768px widths: **+6**
- `Gifts` page: no horizontal scroll bar between 768px and 380px widths: **+6**
5. During smooth resizing of the browser window from 1440px to 380px, the layout occupies the full width of the window (including specified margins), elements adjust their sizes and positions appropriately without full scaling, no elements overlap, and images maintain their correct aspect ratios: **+8**
- On `Home` page: **+4**
- On `Gifts` page: **+4**
6. At screen widths of 768px, the menu and navigation links in `<header>` are concealed on both pages, and a burger menu icon is displayed: **+4**
(Note: Activation of the burger menu icon is not evaluated at this stage.)
7. Hover effects are active on desktop devices (as per the `Desktop` device type in DevTools) and are disabled for mobile devices (as per the `Mobile` device type in DevTools) on both pages: **+4**
8. The layout for both pages is validated and error-free according to the W3C Validator (https://validator.w3.org/): **+12**

### Penalties

1. The layout of the entire design or individual blocks is implemented using images, except in cases where the image is specifically required by the design.
2. The use of frameworks, libraries, and technologies that are prohibited in the [Technical Requirements](./christmas-shop.md#technical-requirements).

## Criteria for Evaluation

**Maximum score for the task: 100 points**

The scoring for each requirement is detailed in the [CrossCheck Criteria](#crosscheck-criteria) section.

Any disputed issues should be resolved in favor of the student being assessed.

## DevTools Responsiveness Check Details

1. To open Developer Tools:
- Press the `F12` key, or right-click and choose the `Inspect` option in the context menu;
- Click on the **Toggle Device Toolbar** icon in the top-right corner of the Developer Tools panel;
- Select **Responsive** on the top panel.
2. Ensure there is no vertical scrollbar in **Responsive** mode. If a scrollbar is present, eliminate it by:
- Switch the device type from `Desktop` to `Mobile` in the Device Toolbar panel;
- If the device type is not visible, click on the three dots on the right in the Device Toolbar panel and choose `Add device type`.
3. Adjust the screen width to the specified value in the task description to check the layout against the Figma design. If the website page does not reformat correctly, or if there is a white space on the right, you may need to refresh the page multiple times.
4. Compare the layout with the Design for accuracy.
5. To test responsiveness at various screen widths, smoothly change the screen width in DevTools from the maximum (1440px) to the minimum (380px), and verify there is no horizontal scrollbar at any width. If a scrollbar or white space on the right emerges, refresh the page as the layout might not have updated correctly.
6. When scaling the screen (e.g., zoom to 125%), the actual width might differ by 1-2 pixels. For example, the actual value might be 767px or 769px even though the Developer Tools indicate 768px. Adjust to the transition point despite this discrepancy.
7. Confirm that hover effects on interactive elements are deactivated in the `Mobile` device type. Click on an interactive element to ensure it does not remain in a hover state. Then, switch to the `Desktop` device type to check that hover effects are functional.

![image](https://user-images.githubusercontent.com/73646765/223966120-845e2526-c54c-4611-8173-db5f9a2c3faa.png)

## Specifics of Verifying Layout

- A deviation of up to 10px horizontally and vertically from the layout is permissible as long as visual congruity between the design and the markup is preserved.
- Utilize the [PerfectPixel](https://chrome.google.com/webstore/detail/perfectpixel-by-welldonec/dkaagdgjmgdmbnecmcefdhjekcoceebi?hl=ru) Chrome extension to verify alignment with the design.
- When using the PerfectPixel extension, ensure it is set to a scale factor of 1, and that your browser and operating system are set to 100% scale.
- Each block and section should be evaluated independently; deficiencies in one block should not affect the assessment of subsequent blocks. Start each new block's review with it aligned to the overlaid layout from PerfectPixel.
- For text, check its alignment and spacing within the confines of the block. Text sizes should be checked only for their height. Variations in word width and letter spacing are not considered errors as long as the correct font with specified properties is used.

## How to Submit

- **Christmas Shop. Part-2 - Responsive Design** task is evaluated through a cross-check process.
- Upon receipt of the task and prior to the submission deadline, proceed to the RS App at https://app.rs.school/. Navigate to **Cross-Check: Submit**, select the appropriate task from the dropdown list, and enter the URL of your deployed website into the **Solution URL** field. Then click the **Submit** button.

## Submit Recommendations

- Aim to submit early once the submission option becomes available in the RS App. You are free to make additional changes up until the deadline.
- Given that the project is contained within a private repository, there's no need to share repository or pull request links as reviewers will not have access to them. Private repositories are visible only to you, the course administrators, and any assigned mentors.
- Verify that the deployed website link is functional, especially when accessed in the browser's incognito mode.

## Task Evaluation

- Follow the instructions for conducting a cross-check available at: https://docs.rs.school/#/cross-check-flow
Loading
Loading